Skip to content

Add Vietnamese translation for Shelley#197

Closed
quangdz-comeback wants to merge 5 commits into
boldsoftware:mainfrom
quangdz-comeback:main
Closed

Add Vietnamese translation for Shelley#197
quangdz-comeback wants to merge 5 commits into
boldsoftware:mainfrom
quangdz-comeback:main

Conversation

@quangdz-comeback
Copy link
Copy Markdown
Contributor

@quangdz-comeback quangdz-comeback commented May 2, 2026

Summary

Add full i18n support for Vietnamese (vi) locale across the UI.

Changes

ui/src/i18n/vi.ts (new file)

  • Vietnamese translation strings for all UI labels

ui/src/i18n/types.ts

  • Added "vi" to the Locale type union
  • Added vietnamese: string to TranslationKeys interface

ui/src/i18n/context.tsx

  • Added import { vn } from "./vi"
  • Added vi: vn entry to the translations record

ui/src/i18n/index.ts

  • Added export { vn } from "./vi"

ui/src/components/ChatInterface.tsx

  • Added { locale: "vi", flag: "🇻🇳", label: "Tiếng Việt" } to LANGUAGE_OPTIONS

Verification:

image

@exedev-shelley
fix: register Vietnamese (vi) locale in i18n types, context, and index
ef9e0b5 
The vi.ts translation file and dropdown option were added, but the locale
was never registered in the type union, translations map, or module exports.
This caused a white screen crash when selecting Vietnamese because
translations['vi'] was undefined.

Co-authored-by: Shelley <shelley@exe.dev>
@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented May 2, 2026

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: exe.dev user.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

philz
philz requested changes May 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@philz philz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!

Thanks for your PR!

It seems to be missing the actual file of translations; can you update it?

There's also some confusion between vn and vi.

Thanks!

@quangdz-comeback @exedev-shelley
feat(i18n): add Vietnamese (vi) language support
ca7a6ac 
- Add Vietnamese translation file vi.ts
- Update all existing i18n files to include Vietnamese locale
- Update ChatInterface with Vietnamese flag icon

Co-authored-by: Shelley <shelley@exe.dev>
@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented May 6, 2026

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: exe.dev user.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented May 6, 2026

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: exe.dev user.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@quangdz-comeback
Copy link
Copy Markdown
Contributor Author

quangdz-comeback commented May 6, 2026

I added all the files now. Please check the repo again and merge my commit.

quangdz-comeback and others added 2 commits May 7, 2026 02:56
@quangdz-comeback @exedev-shelley
Merge upstream/main: sync 16 commits from boldsoftware/shelley
5d05853 
Upstream changes include:
- i18n: Vietnamese locale properly wired (vi, not vn)
- UI: message styling, speaker accent rails, sans font
- LLM: Gemini reasoning effort, GPT-5.5, DeepSeek V4 Pro
- Tools: browser_network clear_cache, shell tool in predictable
- Skills: conditional skills via 'when:', reflection-integration
- Settings: per-conversation tool overrides, reset-to-defaults
- Various fixes and improvements

Resolved: i18n locale naming (vi vs vn), duplicate vi entry in ChatInterface
Co-authored-by: Shelley <shelley@exe.dev>
@quangdz-comeback
Merge remote-tracking branch 'origin/main'
336c5a9
@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented May 7, 2026

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: exe.dev user.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philz philz philz requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@quangdz-comeback @philz