Skip to content

Ensure messages are deduplicated based on model id #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Ensure messages are deduplicated based on model id #205

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4de2d69
Ensure messages are deduplicated based on model id
philippjfr Apr 19, 2024
ec910cc
Fix types
philippjfr Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/widgets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ type DocumentChangedEvent = any
type Receiver = any
type Fragment = any
type HasProps = any
type Ref = any

const { keys, values } = Object

Expand All @@ -29,6 +28,10 @@ export type RenderBundle = {
div: string
}

export interface Ref {
id: string
}

export interface DocumentChanged {
event: 'jsevent'
kind: string
Expand All @@ -37,7 +40,7 @@ export interface DocumentChanged {
export interface ModelChanged extends DocumentChanged {
event: 'jsevent'
kind: 'ModelChanged'
id: string
model: Ref
new: unknown
attr: string
}
Expand Down Expand Up @@ -169,7 +172,7 @@ export class BokehView extends DOMWidgetView {
if (new_msg.kind != msg.kind) {
new_msgs.push(msg)
} else if (msg.kind == 'ModelChanged' && new_msg.kind == 'ModelChanged') {
if (msg.id != new_msg.id || msg.attr != new_msg.attr) {
if (msg.model.id != new_msg.model.id || msg.attr != new_msg.attr) {
new_msgs.push(msg)
}
} else if (msg.kind == 'MessageSent' && new_msg.kind == 'MessageSent') {
Expand Down