Fix output strategy handling in NetworkClient client-side runs - #1
Open
bohdansolovie wants to merge 5 commits into
Open
Fix output strategy handling in NetworkClient client-side runs#1bohdansolovie wants to merge 5 commits into
bohdansolovie wants to merge 5 commits into
Conversation
**Problem** Strings are used to pass paths around. **Solution** This cleans up the Scala instance construction code.
…rtiesFor (sbt#8641) **Problem** getPropertiesFor method calls getResource().openStream() without checking if getResource returns null. When a resource doesn't exist, this causes a NullPointerException with no context about which resource was missing. **Solution** Added null check before calling openStream() and throw a descriptive FileNotFoundException with the resource name if the resource is not found. This prevents NullPointerException and provides better error messages. Generated-by: Auto
Fixes sbt#8627 - Use ${OUT} placeholder and remove StringVirtualFile1 special-case handling - Make dirZipExt check generic (use vf instead of svf: StringVirtualFile1) - Let syncBlobs handle StringVirtualFile1 transparently via fileConverter.toPath()
Replace TODO comments with BufferedOutput strategy for client-side process execution. This prevents output interleaving and ensures consistent logging through the NetworkClient's logger. - Use BufferedOutput(log) for both JVM and native runs - Buffers output until completion, then logs through console interface - Prevents interleaving with NetworkClient's synchronized output handling Generated-by: Gen-AI tools
bohdansolovie
force-pushed
the
fix/network-client-output-strategy
branch
from
January 28, 2026 23:32
26707d0 to
c48d387
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes TODO comments by implementing proper output strategy handling for client-side process execution in NetworkClient.
Changes:
NoneoutputStrategy withBufferedOutput(log)for both JVM and native runsWhy BufferedOutput?
The TODO explicitly requested "buffered output" handling. BufferedOutput: