Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Renderer errors with --enable-frozen-string-literal #244

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anthonykaufman
Copy link

@anthonykaufman anthonykaufman commented Nov 18, 2024

There were several instances in which adding .b to string literals was necessary to not throw this error when --enable-frozen-string-literal was enabled.

To reproduce I used Ruby 2.7.8 with the --enable-frozen-string-literal option enabled:

$ git checkout frozen-string-literal-errors
$ rbenv local 2.7.8
$ git checkout master -- lib/combine_pdf/renderer.rb
$ rake RUBYOPT="--enable-frozen-string-literal --debug-frozen-string-literal" test

You should get 3 test errors.

@boazsegev
Copy link
Owner

Hi,

I'm sorry I missed this. Did the 1.0.29 version fix this issue, or do I still need to fix and merge?

Thanks.
B.

There were several instances in which adding .b to string literals was
necessary to not throw this error when --enable-frozen-string-literal
was enabled. Exposed with tests.
@anthonykaufman anthonykaufman force-pushed the frozen-string-literal-errors branch from 70e51ab to a30667c Compare December 6, 2024 18:05
@anthonykaufman
Copy link
Author

No worries!

I rebased on master and without the changes I made to lib/combine_pdf/renderer.rb in the PR, I'm still failing the tests I created to expose the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants