Swallow "index out of range" error #209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* introduce raise_on_encrypted option * add some detail to the exception * update the README to specify the raise_on_encrypted option * 🔪 the CombinePDF.encrypted? method that is no longer needed * apply patch from @kimyu92 * add guards * docs + cleanup * fix release date in changelog * Adds Github Actions workflow for tests - Allows us to test the gem on multiple versions of Ruby --------- Co-authored-by: Levi Wilson <[email protected]> Co-authored-by: Bo <[email protected]> Co-authored-by: David Wessman <[email protected]>
This was referenced Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Personal response to #205
Our clients are importing a lot of PDFs, so we needed a workaround for these "malformed" files.
This quick fix is working for us, but feel free to inform me of any trouble it could cause in the future.
Not expecting you to merge it as well, I just wanted to propose this solution for people in the same context.