Skip to content

refactor(skills): remove unused skill_path references#19

Open
alexeyv wants to merge 1 commit intobmad-code-org:mainfrom
alexeyv:refactor/remove-skill-path-refs
Open

refactor(skills): remove unused skill_path references#19
alexeyv wants to merge 1 commit intobmad-code-org:mainfrom
alexeyv:refactor/remove-skill-path-refs

Conversation

@alexeyv
Copy link
Copy Markdown

@alexeyv alexeyv commented Apr 2, 2026

Summary

  • Remove unused skill_path variable definitions from all 4 workflow skills (storytelling, design-thinking, innovation-strategy, problem-solving)
  • These referenced {project-root}/_bmad/cis/workflows/ which will no longer be populated after the BMAD installer change to stop installing prompts under _bmad
  • The variable was defined but never referenced elsewhere in any workflow, so this is a no-op cleanup

Note on remaining _bmad references

All remaining {project-root}/_bmad/ references in CIS skill prompts are to either:

  • _bmad/cis/config.yaml — module configuration (all 6 agent skills + 4 workflow skills)
  • _bmad/_memory/storyteller-sidecar/ — runtime sidecar files created and managed by the storyteller skill itself (story-preferences.md, stories-told.md)

No skill prompts reference other prompts via _bmad paths.

Test plan

  • Verified skill_path is not referenced anywhere else in the project
  • Confirm workflows still function correctly without the variable

Summary by CodeRabbit

  • Chores
    • Removed internal path references from workflow configuration files across multiple skill modules. No changes to end-user functionality or visible features.

skill_path pointed to {project-root}/_bmad/cis/workflows/ which will no
longer exist after the BMAD installer change to stop installing prompts
under _bmad. The variable was defined but never referenced elsewhere in
any workflow.
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7ca879ad-d217-49b8-b7e3-66c158c1a629

📥 Commits

Reviewing files that changed from the base of the PR and between 5edbda9 and f6e9db1.

📒 Files selected for processing (4)
  • src/skills/bmad-cis-design-thinking/workflow.md
  • src/skills/bmad-cis-innovation-strategy/workflow.md
  • src/skills/bmad-cis-problem-solving/workflow.md
  • src/skills/bmad-cis-storytelling/workflow.md
💤 Files with no reviewable changes (4)
  • src/skills/bmad-cis-design-thinking/workflow.md
  • src/skills/bmad-cis-innovation-strategy/workflow.md
  • src/skills/bmad-cis-problem-solving/workflow.md
  • src/skills/bmad-cis-storytelling/workflow.md

Walkthrough

This PR removes skill_path variable declarations from the "Paths" section of four workflow configuration files within the bmad-cis skills directory. The removals do not impact other path variables or workflow functionality.

Changes

Cohort / File(s) Summary
Workflow Configuration Updates
src/skills/bmad-cis-design-thinking/workflow.md, src/skills/bmad-cis-innovation-strategy/workflow.md, src/skills/bmad-cis-problem-solving/workflow.md, src/skills/bmad-cis-storytelling/workflow.md
Removed skill_path variable definitions from the "Paths" section in each workflow configuration file. All other path and template variables remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • bmadcode

Poem

🐰 Hop, hop—the paths are simplified,
Four workflows light, no skill_path to guide,
We bundle up the clutter, tidy and clean,
The prettiest workflows you've ever seen!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing unused skill_path references from workflow files across multiple skills.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@augmentcode
Copy link
Copy Markdown

augmentcode bot commented Apr 2, 2026

🤖 Augment PR Summary

Summary: Removes the unused skill_path variable from all CIS workflow skill definitions.

Why: The referenced {project-root}/_bmad/cis/workflows/... location will no longer be installed, and skill_path wasn’t referenced elsewhere, making this a safe no-op cleanup.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants