refactor: replace bmad-init with direct config loading#17
Conversation
…cess
Update all 6 CIS agents to load config directly from
{project-root}/_bmad/cis/config.yaml instead of delegating to the
bmad-init skill. Remove empty frontmatter from 4 workflow files.
WalkthroughThis PR modifies configuration loading patterns across six agent skills to directly read from a configuration file instead of relying on an initialization skill, and removes the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🤖 Augment PR SummarySummary: Refactors Creative Intelligence Suite (CIS) agents/workflows to remove reliance on the deprecated Changes:
Technical Notes: This aligns CIS with upstream framework changes (BMAD-METHOD#2159) that removed the 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| - Use `{user_name}` for greeting | ||
| - Use `{communication_language}` for all communications | ||
| - Use `{document_output_language}` for output documents | ||
|
|
There was a problem hiding this comment.
This now instructs agents to use {document_output_language}, but this repo’s CIS configuration reference/defaults only define output_folder, user_name, and communication_language; if the key isn’t present in a user’s _bmad/cis/config.yaml, the placeholder could remain unresolved or lead to inconsistent document language. Consider confirming this config key is part of the supported contract (and documented) wherever CIS config defaults are defined.
Severity: medium
Other Locations
src/skills/bmad-cis-agent-creative-problem-solver/SKILL.md:42src/skills/bmad-cis-agent-design-thinking-coach/SKILL.md:43src/skills/bmad-cis-agent-innovation-strategist/SKILL.md:42src/skills/bmad-cis-agent-presentation-master/SKILL.md:53src/skills/bmad-cis-agent-storyteller/SKILL.md:47
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/skills/bmad-cis-agent-design-thinking-coach/SKILL.md`:
- Around line 39-42: The activation flow currently trusts loading
`{project-root}/_bmad/cis/config.yaml` and can hard-fail; update the
config-loading logic to catch file-not-found and YAML parse errors, validate
presence of `{user_name}`, `{communication_language}`, and
`{document_output_language}` keys, and apply safe defaults (e.g.,
user_name="User", communication_language="en", document_output_language="en")
when missing or invalid; ensure errors are logged (warning for missing keys,
error for parse failures) but do not throw, and keep the agent activation
predictable by proceeding with the defaulted values and replacing placeholders
accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c1a8014c-8328-4627-8968-76f6278923c4
📒 Files selected for processing (10)
src/skills/bmad-cis-agent-brainstorming-coach/SKILL.mdsrc/skills/bmad-cis-agent-creative-problem-solver/SKILL.mdsrc/skills/bmad-cis-agent-design-thinking-coach/SKILL.mdsrc/skills/bmad-cis-agent-innovation-strategist/SKILL.mdsrc/skills/bmad-cis-agent-presentation-master/SKILL.mdsrc/skills/bmad-cis-agent-storyteller/SKILL.mdsrc/skills/bmad-cis-design-thinking/workflow.mdsrc/skills/bmad-cis-innovation-strategy/workflow.mdsrc/skills/bmad-cis-problem-solving/workflow.mdsrc/skills/bmad-cis-storytelling/workflow.md
💤 Files with no reviewable changes (4)
- src/skills/bmad-cis-storytelling/workflow.md
- src/skills/bmad-cis-innovation-strategy/workflow.md
- src/skills/bmad-cis-design-thinking/workflow.md
- src/skills/bmad-cis-problem-solving/workflow.md
| 1. Load config from `{project-root}/_bmad/cis/config.yaml` and resolve: | ||
| - Use `{user_name}` for greeting | ||
| - Use `{communication_language}` for all communications | ||
| - Use `{document_output_language}` for output documents |
There was a problem hiding this comment.
Define fallback/error handling for config load failures.
This activation flow can hard-fail if config.yaml is missing, malformed, or missing keys. Add explicit fallback/default behavior so agent activation remains predictable.
Suggested doc patch
1. Load config from `{project-root}/_bmad/cis/config.yaml` and resolve:
- Use `{user_name}` for greeting
- Use `{communication_language}` for all communications
- Use `{document_output_language}` for output documents
+ - If file is missing/invalid, continue with safe defaults:
+ - `{user_name}` = `there`
+ - `{communication_language}` = `English`
+ - `{document_output_language}` = `{communication_language}`
+ - If any key is missing, apply the same defaults and continue.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| 1. Load config from `{project-root}/_bmad/cis/config.yaml` and resolve: | |
| - Use `{user_name}` for greeting | |
| - Use `{communication_language}` for all communications | |
| - Use `{document_output_language}` for output documents | |
| 1. Load config from `{project-root}/_bmad/cis/config.yaml` and resolve: | |
| - Use `{user_name}` for greeting | |
| - Use `{communication_language}` for all communications | |
| - Use `{document_output_language}` for output documents | |
| - If file is missing/invalid, continue with safe defaults: | |
| - `{user_name}` = `there` | |
| - `{communication_language}` = `English` | |
| - `{document_output_language}` = `{communication_language}` | |
| - If any key is missing, apply the same defaults and continue. |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/skills/bmad-cis-agent-design-thinking-coach/SKILL.md` around lines 39 -
42, The activation flow currently trusts loading
`{project-root}/_bmad/cis/config.yaml` and can hard-fail; update the
config-loading logic to catch file-not-found and YAML parse errors, validate
presence of `{user_name}`, `{communication_language}`, and
`{document_output_language}` keys, and apply safe defaults (e.g.,
user_name="User", communication_language="en", document_output_language="en")
when missing or invalid; ensure errors are logged (warning for missing keys,
error for parse failures) but do not throw, and keep the agent activation
predictable by proceeding with the defaulted values and replacing placeholders
accordingly.
1 participant
Summary
{project-root}/_bmad/cis/config.yamlTest plan
Summary by CodeRabbit
Refactor
Chores