Skip to content

refactor: allow dev-story skill to modify Review Findings todo items #2189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cantecim wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: allow dev-story skill to modify Review Findings todo items #2189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/bmm-skills/4-implementation/bmad-dev-story/workflow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
**Your Role:** Developer implementing the story.
- Communicate all responses in {communication_language} and language MUST be tailored to {user_skill_level}
- Generate all documents in {document_output_language}
- Only modify the story file in these areas: Tasks/Subtasks checkboxes, Dev Agent Record (Debug Log, Completion Notes), File List, Change Log, and Status
- Only modify the story file in these areas: Tasks/Subtasks checkboxes, Dev Agent Record (Debug Log, Completion Notes), File List, Change Log, Review Findings, and Status
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Critical: Write conflict with code-review workflow.

Adding "Review Findings" to the permitted modification areas creates a write conflict. The bmad-code-review workflow (specifically src/bmm-skills/4-implementation/bmad-code-review/steps/step-04-present.md:19-36) also creates and writes to the "### Review Findings" subsection in the story file. Both workflows now claim write access to the same section with no defined precedence or coordination mechanism, which can lead to:

  • Race conditions if both workflows run concurrently
  • Lost updates when one workflow overwrites the other's changes
  • Undefined behavior regarding which agent's modifications take precedence

Recommendation: Clarify the ownership model for "Review Findings":

  1. If dev-story should only read Review Findings (to execute follow-ups), remove it from the write-permitted list
  2. If dev-story should mark findings complete, add a subsection like "Review Findings Status" that only dev-story writes to, while code-review owns the findings themselves
  3. If both need write access, document the coordination protocol (e.g., code-review creates, dev-story only checks boxes)
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@src/bmm-skills/4-implementation/bmad-dev-story/workflow.md` at line 8, The
story workflow currently claims write access to the "### Review Findings"
subsection which conflicts with the bmad-code-review workflow (see
bmad-code-review steps/step-04-present.md) that also writes that subsection;
update the story workflow (the allowed-modifications list in the workflow.md) to
remove "Review Findings" from writable areas and instead add a new subsection
name such as "Review Findings Status" that this dev-story can write; ensure any
automation that reads the original "Review Findings" still treats it as
read-only and update references to "Review Findings" in
src/bmm-skills/4-implementation/bmad-dev-story/workflow.md to point to the new
"Review Findings Status" when marking completion so only code-review owns the
actual findings while dev-story only updates status.

- Execute ALL steps in exact order; do NOT skip steps
- Absolutely DO NOT stop because of "milestones", "significant progress", or "session boundaries". Continue in a single execution until the story is COMPLETE (all ACs satisfied and all tasks/subtasks checked) UNLESS a HALT condition is triggered or the USER gives other instruction.
- Do NOT schedule a "next session" or request review pauses unless a HALT condition applies. Only Step 6 decides completion.
Expand Down