fix(metric): collect all disk partitions instead of only physical partitions

[mertssmnoglu]

Description of changes

When reading the disks, take all partitions instead of physical partitions to show virtual disk partitions correctly.

Issue Number

Fix for the #43

Summary by CodeRabbit

• New Features
  • Updated disk metrics collection to retrieve all disk partitions instead of filtering specific ones.

[coderabbitai]

Walkthrough

The pull request modifies the CollectDiskMetrics function in the internal/metric/disk.go file. The key change is in the disk.Partitions() method call, where the boolean parameter has been switched from false to true. This modification means the function will now retrieve all disk partitions instead of filtering out certain partitions. The change impacts how disk metrics are collected, expanding the scope of partition detection to include all available partitions in the system.

Changes

File	Change Summary
internal/metric/disk.go	Modified CollectDiskMetrics function to retrieve all disk partitions by changing disk.Partitions(false) to disk.Partitions(true)

Suggested labels

enhancement

Suggested reviewers

• ajhollid

Possibly related PRs

• Multi partition support #32: Changes in CollectDiskMetrics function related to disk partition retrieval logic

Poem

🐰 A Rabbit's Ode to Disk Metrics

All partitions now in sight,
No more hiding from the light!
From system drives to user's space,
We'll track each disk with rabbit grace 🕵️‍♂️💽

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2f8f3f9 and a0e10d8.

📒 Files selected for processing (1)

• internal/metric/disk.go (1 hunks)

🔇 Additional comments (1)

internal/metric/disk.go (1)

23-24: LGTM! The change aligns with PR objectives.

The modification to include all partitions instead of just physical ones correctly implements the requirement to collect metrics from all disk partitions, including virtual ones.

Consider monitoring the performance impact of processing additional partitions. Run this script to analyze the potential increase in partition count:

✅ Verification successful

The change to include all partitions is safe and well-implemented

The codebase inspection reveals:

• Robust error handling for partition retrieval
• Post-retrieval filtering to exclude unwanted partitions
• Safe processing of the expanded partition set

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Compare the number of partitions that would be processed before and after the change

# Install gopsutil
go get github.com/shirou/gopsutil/v4

# Create a test program
cat > test.go << 'EOL'
package main

import (
    "fmt"
    "github.com/shirou/gopsutil/v4/disk"
)

func main() {
    physical, _ := disk.Partitions(false)
    all, _ := disk.Partitions(true)
    fmt.Printf("Physical partitions: %d\n", len(physical))
    fmt.Printf("All partitions: %d\n", len(all))
}
EOL

# Run the test
go run test.go

Length of output: 597

---

Script:

#!/bin/bash
# Check error handling and filtering logic for disk partitions

# Search for partition filtering logic
echo "=== Searching for partition filtering logic ==="
rg -A 10 "disk.Partitions" internal/metric/

# Check error handling
echo -e "\n=== Checking error handling ==="
ast-grep --pattern 'if $err != nil {
  $$$
}'  internal/metric/disk.go

Length of output: 853

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.