-
Notifications
You must be signed in to change notification settings - Fork 62
fix: The built UI app was placed in the wrong location. #1140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The CI check meant to catch any issues with this: Lines 50 to 61 in 08f5d00
is passing on
and I cannot immediately see why. |
This reverts commit 1207eb0.
Now I understand why our builds were so slow: we were copying |
I believe this is now in working order, but it remains to sort out why the tests passed even when the UI was missing/broken. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look reasonable to me. Merge when ready.
Investigation into tests spun off into #1143. |
Closes #1139, improves the container image build in related ways, and fixes a recent regression which broke the "secret" feature enabling
?api_key
to be moved to a cookie so that API key auth could work with the React UI.Checklist