Skip to content

Conversation

danielballan
Copy link
Member

@danielballan danielballan commented Sep 5, 2025

Closes #1139, improves the container image build in related ways, and fixes a recent regression which broke the "secret" feature enabling ?api_key to be moved to a cookie so that API key auth could work with the React UI.

Checklist

  • Add a Changelog entry
  • Add the ticket number which this PR closes to the comment section

@danielballan
Copy link
Member Author

The CI check meant to catch any issues with this:

- name: http
description: Serves a UI at /ui/browse
probe:
httpGet:
path: /ui/browse
port: 8000
initialDelaySeconds: 15
timeoutSeconds: 10
failureThreshold: 3
httpHeaders:
- name: Authorization
value: Apikey secret

is passing on main:

 Serves a UI at /ui/browse                          [passed]

and I cannot immediately see why.

@danielballan
Copy link
Member Author

Now I understand why our builds were so slow: we were copying .git into the one of the build stages. I think this may have also affected the byte-compiling time.

@danielballan
Copy link
Member Author

I believe this is now in working order, but it remains to sort out why the tests passed even when the UI was missing/broken.

Copy link
Contributor

@padraic-shafer padraic-shafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look reasonable to me. Merge when ready.

@danielballan
Copy link
Member Author

Investigation into tests spun off into #1143.

@danielballan danielballan merged commit 08c27b3 into bluesky:main Sep 10, 2025
11 checks passed
@danielballan danielballan deleted the fix-ui-in-container branch September 10, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web UI not available from container
2 participants