✨ Recursively load queue pages if current page is empty #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
avoid-empty-queue-page - ozone-staging PR #185
Render
Destroyed
devinivy
approved these changes
Sep 11, 2024
devinivy
reviewed
Sep 11, 2024
app/reports/page-content.tsx
Outdated
Comment on lines
392
to
395
| // This is a recursive call to get items in queue if the current page | ||
| // gives us less than full page size and there are more items to fetch | ||
| if (statusesInQueue.length === 0 && data.cursor) { | ||
| return getQueueItems( |
There was a problem hiding this comment.
Only think I am a little unsure about here is that it would be easy to create a bug on the server side that causes this to spin and cause tons of requests. The fix, I think, would be to pass a counter as a last arg to getQueueItems() that ensures we don't fetch more than maybe 10-15 pages this way.
arcalinea
temporarily deployed
to
avoid-empty-queue-page - ozone-staging PR #185
Render
Destroyed
devinivy
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids showing empty queue or hitting
Load Moreand not getting new items when multiple queues are active.