Pinned posts #2771
Pinned posts #2771
Conversation
mozzius
force-pushed
the
samuel/pinned-posts
branch
from
f145759
to
456c8f9
Compare
|
Ah one thing: if you pin a reply, it only shows up in your posts & replies 🤔 |
| // @NOTE the feed item types in the protos for author feeds and timelines | ||
| // technically have additional fields, not supported by the mock dataplane. | ||
| export type FeedItem = { post: ItemRef; repost?: ItemRef } | ||
| export type FeedItem = { | ||
| post: ItemRef | ||
| repost?: ItemRef | ||
| /** | ||
| * If true, overrides the `reason` with `app.bsky.feed.defs#reasonPin`. Used | ||
| * only in author feeds. | ||
| */ | ||
| authorPinned?: boolean | ||
| } |
There was a problem hiding this comment.
This is the part I'm least sure about - is it ok to add this extra field here?
There was a problem hiding this comment.
Yeah this type of a bit funny and could honestly probably find a cozier spot. This type is only used as a parameter for both hydration & views. So you should be good to add this extra property here. The lil note is appreciated 👍
| const pinnedItem = { | ||
| post: { | ||
| uri: actor.profile.pinnedPost.uri, | ||
| cid: actor.profile.pinnedPost.cid, | ||
| }, | ||
| repost: undefined, | ||
| authorPinned: true, | ||
| } |
There was a problem hiding this comment.
I set authorPinned here, I'm not expecting the value to come from the dataplane or anything so I imagine it should be fine (but would be good to confirm)
| @@ -186,6 +194,10 @@ | |||
| "repost": { "type": "string", "format": "at-uri" } | |||
| } | |||
| }, | |||
| "skeletonReasonPin": { | |||
There was a problem hiding this comment.
I actually like that this could be used in the future for a feed gen to "pin" a post to the top of a feed
| @@ -44,7 +44,8 @@ | |||
| "like": { "type": "string", "format": "at-uri" }, | |||
| "threadMuted": { "type": "boolean" }, | |||
| "replyDisabled": { "type": "boolean" }, | |||
| "embeddingDisabled": { "type": "boolean" } | |||
| "embeddingDisabled": { "type": "boolean" }, | |||
| "pinned": { "type": "boolean" } | |||
There was a problem hiding this comment.
Just curious, does this affect the presentation of a post elsewhere in the app (other than a user's own author feed) when viewing their own pinned post?
There was a problem hiding this comment.
We use it to show "Pin post" or "Unpin post" in the context menu
packages/bsky/src/data-plane/server/db/migrations/20240831T134810923Z-pinned-posts.ts
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,17 @@ | |||
| import { Kysely } from 'kysely' | |||
There was a problem hiding this comment.
The backend isn't using Scylla? What is this kysely about? Just curious
There was a problem hiding this comment.
this is the Postgres-based reference implementation
Behavior on author feed:
#reasonPinviewer.pinnedremains the same in either case, and should betrueBehavior in other feeds:
viewer.pinnedshould reflectprofile.pinnedPost