Change max length of names to 64 graphemes #2628
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Something that got surfaced by starter packs is that lists currently allow only 64 utf-8 bytes, not 64 graphemes. This is extremely restrictive, especially for foreign languages which use non-roman alphabets. For example, just adding the word
hello
to a list name (i.e.こんにちは
) takes up 15 bytes.I think bumping this to what I suspect is the intended max limit should be okay, since any previously created list should already be compliant with this. One thing to note of course would be that existing clients would maybe have problems when receiving a response that includes a starter pack with a longer name. At least for us, we could OTA something to the past few versions to help ease that concern.