add deploy_dir flag to build command#103
Open
Perelyn-sama wants to merge 4 commits intoblueshift-gg:masterfrom
Open
add deploy_dir flag to build command#103Perelyn-sama wants to merge 4 commits intoblueshift-gg:masterfrom
Perelyn-sama wants to merge 4 commits intoblueshift-gg:masterfrom
Conversation
src/main.rs
Outdated
| match &cli.command { | ||
| Commands::Init(args) => init(args.name.clone(), args.ts_tests), | ||
| Commands::Build(args) => build(args.debug, args.static_syscalls), | ||
| Commands::Build(args) => build(args.debug, args.static_syscalls, args.deploy_dir.clone()), |
Collaborator
There was a problem hiding this comment.
the change makes sense to me, but could you make these commands take xxArgs as the only input instead, then break it down in each xx.rs? so that the next time we add more arguments, we don't change it again and it doesn't grow into a messy list in the future
Collaborator
|
change is good, please address failed checks :D |
fmt fix
Author
addressed :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need this in the program examples repo to maintain our CI workflow for sbpf asm examples
cargo build-sbfhas a--sbf-out-dirflag for custom output directories butsbpfcurrently doesn't