Adding hyperlinks to blog post titles.#10
Open
sergiotarxz wants to merge 2 commits intobludit-themes:masterfrom
Open
Adding hyperlinks to blog post titles.#10sergiotarxz wants to merge 2 commits intobludit-themes:masterfrom
sergiotarxz wants to merge 2 commits intobludit-themes:masterfrom
Conversation
…malink is used as a title. Issue bludit-themes#2
Open
Collaborator
|
What happen if the title is empty? I want to show empty. |
Contributor
Author
|
Maybe I can do a smaller link to article in this case, printing permalink as title can be weird. |
So pages which you don't want to have title won't have a big permalink. Issue bludit-themes#2
Contributor
Author
Maybe the solution I have come now is more elegant, I have added a link to the article in the footer and removed the need to print the title if you don't want to put one title will be anyway a permalink but there is no need to have a title. |
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding hyperlinks to blog post titles, if there is no title, page permalink is used as a title.
Issue #2
The usage of htmlentities is related to issue #4, I filtered also
'in urls because there is a chance other people commiting changes to this repo without knowing htmlentities by default doesn't filter'and using'as href delimiter.