Include sync check for dry run and reduce spamming #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check md5 hash on dry run to know what will be copied for the real run. Suppress output for already synced messages unless verbose is specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's convenient to be able to use --dry-run to see what changes would be synced when syncing directories.
If syncing a previously synced directory, the dry-run step must include the sync_check (ie check of md5 hash) to be able to indicate what will be uploaded.
Also, if there are many files where only a handful have changed there will be a lot of spam with "(synced)" entries of all the unchanged files, so only print these lines if verbose output is enabled.
These changes makes the output of s4cmd look more like s3cmd when syncing directories.