-
Notifications
You must be signed in to change notification settings - Fork 331
ReactTesting({BrianWilliams: " -___- "}) #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bkwillia052
wants to merge
5
commits into
bloominstituteoftechnology:master
Choose a base branch
from
bkwillia052:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,83 @@ | ||
| import React from 'react'; | ||
| import { shallow } from 'enzyme'; | ||
| import { shallow, mount } from 'enzyme'; | ||
|
|
||
| import Display from '../components/Display/Display'; | ||
| import App from '../App'; | ||
| import Panel from '../components/Panel/Panel'; | ||
|
|
||
| describe('<Display />', () => { | ||
| it('renders without crashing', () => { | ||
| shallow(<Display />); | ||
| it('renders shallow without crashing', () => { | ||
| shallow(<Display />); | ||
| }); | ||
| }); | ||
| it('renders prop name in div', () => { | ||
| const wrapper = shallow(<Display value="abcd" />); | ||
| const finder = wrapper.find('div'); | ||
|
|
||
| expect(finder.last().text()).toBe('abcd'); | ||
| }); | ||
| it('renders prop name in div', () => { | ||
| const wrapper = shallow(<Display value="abcd" />); | ||
| const finder = wrapper.find('.component-display'); | ||
|
|
||
| expect(finder.last().text()).toBe('abcd'); | ||
| }); | ||
| it('renders depending on App state', () => { | ||
| const wrapper = mount( | ||
| <App> | ||
| <Display /> | ||
| <Panel /> | ||
| </App> | ||
| ); | ||
| const disp = wrapper.find('.component-display'); | ||
| wrapper | ||
| .find('button') | ||
| .filterWhere(btn => btn.text() === '7') | ||
| .simulate('click'); | ||
| expect(disp.text()).toBe('7'); | ||
| wrapper | ||
| .find('button') | ||
| .filterWhere(btn => btn.text() === '9') | ||
| .simulate('click'); | ||
| expect(disp.text()).toBe('79'); | ||
| }); | ||
| it('renders calculated value', () => { | ||
| const wrapper = mount( | ||
| <App> | ||
| <Display /> | ||
| <Panel /> | ||
| </App> | ||
| ); | ||
| const disp = wrapper.find('.component-display'); | ||
| wrapper | ||
| .find('button') | ||
| .filterWhere(btn => btn.text() === '7') | ||
| .simulate('click'); | ||
| expect(disp.text()).toBe('7'); | ||
| wrapper | ||
| .find('button') | ||
| .filterWhere(btn => btn.text() === '+') | ||
| .simulate('click'); | ||
| wrapper | ||
| .find('button') | ||
| .filterWhere(btn => btn.text() === '9') | ||
| .simulate('click'); | ||
| wrapper | ||
| .find('button') | ||
| .filterWhere(btn => btn.text() === '=') | ||
| .simulate('click'); | ||
| expect(disp.text()).toBe('16'); | ||
| wrapper | ||
| .find('button') | ||
| .filterWhere(btn => btn.text() === '-') | ||
| .simulate('click'); | ||
| wrapper | ||
| .find('button') | ||
| .filterWhere(btn => btn.text() === '6') | ||
| .simulate('click'); | ||
| wrapper | ||
| .find('button') | ||
| .filterWhere(btn => btn.text() === '=') | ||
| .simulate('click'); | ||
| expect(disp.text()).toBe('10'); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,37 @@ | ||
| import React from 'react'; | ||
| import { shallow } from 'enzyme'; | ||
| import { shallow, mount } from 'enzyme'; | ||
|
|
||
| import Panel from '../components/Panel/Panel'; | ||
| import App from '../App'; | ||
|
|
||
| describe('<Panel />', () => { | ||
| it('renders without crashing', () => { | ||
| shallow(<Panel />); | ||
| }); | ||
| }); | ||
| it('renders shallow without crashing', () => { | ||
| shallow(<Panel />); | ||
| }); | ||
| it('renders within <App />', () => { | ||
| const wrapper = mount( | ||
| <App> | ||
| <Panel /> | ||
| </App> | ||
| ); | ||
| expect(wrapper.find('button').length).toBe(19); | ||
| expect(wrapper.find('.component-panel').length).toBe(1); | ||
| }); | ||
| it('button changes state of App', () => { | ||
| const wrapper = mount( | ||
| <App> | ||
| <Panel /> | ||
| </App> | ||
| ); | ||
| wrapper | ||
| .find('button') | ||
| .filterWhere(btn => btn.text() === '7') | ||
| .simulate('click'); | ||
| expect(wrapper.state().next).toBe('7'); | ||
| wrapper | ||
| .find('button') | ||
| .filterWhere(btn => btn.text() === '9') | ||
| .simulate('click'); | ||
| expect(wrapper.state().next).toBe('79'); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job experimenting with mounting! you might find this article interesting https://blog.kentcdodds.com/why-i-never-use-shallow-rendering-c08851a68bb7