Completion of Components-BEM.#96
Open
ShawnStewart wants to merge 2 commits intobloominstituteoftechnology:masterfrom
Open
Completion of Components-BEM.#96ShawnStewart wants to merge 2 commits intobloominstituteoftechnology:masterfrom
ShawnStewart wants to merge 2 commits intobloominstituteoftechnology:masterfrom
Conversation
|
Followed BEM conventions appropriately. Project solution meets requirements except there are no href links for the dropdown options. JS code is concise and self-documenting with use of a single function to toggle the dropdown menu. HTML is clean, organized, and follows BEM convention. It doesn't have unnecessary bloat from extraneous divs and the like. Site is fully responsive with use of media queries. Be sure you're meeting project requirements (no href links for the dropdown options here). And get use to using a file structure as the Section, Box, and Dropdown CSS and JS code should have went into their respective files and directories under components. Overall it was great work. Keep working hard! Rating (0-3): 2.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.