Skip to content

Michal Chmielniak, Iqra Javed, David Morales#92

Open
mgchmiel wants to merge 4 commits intobloominstituteoftechnology:masterfrom
mgchmiel:master
Open

Michal Chmielniak, Iqra Javed, David Morales#92
mgchmiel wants to merge 4 commits intobloominstituteoftechnology:masterfrom
mgchmiel:master

Conversation

@mgchmiel
Copy link
Copy Markdown

No description provided.

@ghost ghost mentioned this pull request Mar 29, 2018
Copy link
Copy Markdown

@BonnW BonnW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey!

Great work on the project today. It seems like you're getting pretty comfortable with components.

There's still some weird styling that I'd like to address;

In Dropdown.js, from lines 3 to 8 should be indented.
Also, When you're building Classes, it is not uncommon to have multiple functions and so it's best practice to include a blank line in between functions to help with readability. An extra blank line between lines 6 and 7 would help make it look a lot neater.

In Section.css, all of .Section is oddly spaced and the rest of the tags are all indented unnecessarily. .Section__Half looks like it is indented twice for no reason.

Great work overall. Remember to work and communicate with your teams to catch these minor issues and succeed together! :D

P.S. Michal, Please use more descriptive commits aside from just WIP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants