first commit: dropdown not working yet#90
Open
Remastered21 wants to merge 3 commits intobloominstituteoftechnology:masterfrom
Open
first commit: dropdown not working yet#90Remastered21 wants to merge 3 commits intobloominstituteoftechnology:masterfrom
Remastered21 wants to merge 3 commits intobloominstituteoftechnology:masterfrom
Conversation
|
I like how you separated out your files, it's a good skill to learn early. You could consider reworking your JS file into using Class syntax for more practice now that you had today's lecture/assignment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project should also be responsive to 400px phone screen size