Open
Conversation
added 4 commits
March 28, 2018 15:19
… content. Moving to styling.
…script. Moving to layout.
What Went Well:Nice work on this project guys. You were able to complete the goals and the code looks good. Excellent use of the naming conventions as well! That's not easy to pick up right away, so good for you guys!Areas For Improvement:Although the JS works, the point of the assignment was to use the ES6 class syntax. If you get a chance, try to refactor.Questions:None, good work!Rating (1-3):2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Robert Hogan, David Finley partner partner project. Assignment completed.