Working on dropdown#86
Open
Julian-Alexander wants to merge 5 commits intobloominstituteoftechnology:masterfrom
Open
Working on dropdown#86Julian-Alexander wants to merge 5 commits intobloominstituteoftechnology:masterfrom
Julian-Alexander wants to merge 5 commits intobloominstituteoftechnology:masterfrom
Conversation
frogr
approved these changes
Mar 29, 2018
frogr
left a comment
frogr
left a comment
There was a problem hiding this comment.
Hey Julian!
This is awesome. You did a very great job!
I don't have any real criticisms here. I think you knocked it out of the park.
The code is clean, your markup is solid, good naming conventions, and it all matches the spec. I have no complaints!
You knocked this one out of the park. Nice work!
| @@ -0,0 +1,13 @@ | |||
| class dropDown { | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.