Components BEM Part 1 HTML, Style.css & index.js#84
Open
mocamanda wants to merge 13 commits intobloominstituteoftechnology:masterfrom
Open
Components BEM Part 1 HTML, Style.css & index.js#84mocamanda wants to merge 13 commits intobloominstituteoftechnology:masterfrom
mocamanda wants to merge 13 commits intobloominstituteoftechnology:masterfrom
Conversation
added 11 commits
March 28, 2018 16:03
…ibute of Lambda, Google & MDN & Script tag to reference main.js
BonnW
approved these changes
Mar 29, 2018
There was a problem hiding this comment.
Hey Amanda!
Great work on today's project as well. Your code is styled perfectly, there are a lot of detailed commits and comments.
I know Chris has been helping you out a lot and I'm really happy to see that you're getting the material :)
My only comment is that DropdownReveal should be Dropdown--Reveal As per the BEM naming convention
Keep up the fantastic work and please feel free to reach out if you feel like you need more help!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.