Iqra Javed: Components-BEM#80
Open
iqra-javed wants to merge 8 commits intobloominstituteoftechnology:masterfrom
Open
Iqra Javed: Components-BEM#80iqra-javed wants to merge 8 commits intobloominstituteoftechnology:masterfrom
iqra-javed wants to merge 8 commits intobloominstituteoftechnology:masterfrom
Conversation
added 8 commits
March 28, 2018 16:22
…e provided activeDropdown.png
BonnW
approved these changes
Mar 29, 2018
BonnW
left a comment
BonnW
left a comment
There was a problem hiding this comment.
Hey Iqra!
Great work on the project! I had written a lengthy review of Michal's PR with the whole group in mind, You can take a look if you'd like #92
Otherwise, In this PR there is just one tiny styling issue; in Section.CSS there's some mismatched styling. You always want to be as consistent as possible but again, this is very minor.
Otherwise, Fantastic Job!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.