Dropdwon has functionality, but needs some tunning to work properly. …#79
Open
abrambueno1992 wants to merge 2 commits intobloominstituteoftechnology:masterfrom
Open
Dropdwon has functionality, but needs some tunning to work properly. …#79abrambueno1992 wants to merge 2 commits intobloominstituteoftechnology:masterfrom
abrambueno1992 wants to merge 2 commits intobloominstituteoftechnology:masterfrom
Conversation
…Wasn't able to complete mobile version, and selections portion.
…e ES6 class to handle click and mouseover events. Along the way, I also fixed some positioning of items.
frogr
approved these changes
Mar 29, 2018
frogr
left a comment
frogr
left a comment
There was a problem hiding this comment.
Hey Abraham!
Overall I'm pretty pleased with this assignment. I think you could've definitely condensed all the CSS into one file (that's better normally so you don't have to load 3 different files on a page, but with toy problems like this it's not too important)
It looks like the dropdown could use a little bit more work, but besides that it pretty much matches the spec. Your names for styling seem pretty consistent too.
Nice work!
| const google = document.querySelector(".Header__google"); | ||
| google.style.backgroundColor = "white"; | ||
| const mdn = document.querySelector(".Header__mdn"); | ||
| mdn.style.backgroundColor = "white"; |
There was a problem hiding this comment.
Still kinda confused as to why you'd want to style using javascript instead of CSS. I think you'd be better off leaving that for just CSS. separation of concerns and all that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dropdwon has functionality, but needs some tunning to work properly. Wasn't able to complete mobile version, and selections portion.