Skip to content

Eric Andrade working with Subra and Aaron#76

Open
buddhaplex wants to merge 4 commits intobloominstituteoftechnology:masterfrom
buddhaplex:master
Open

Eric Andrade working with Subra and Aaron#76
buddhaplex wants to merge 4 commits intobloominstituteoftechnology:masterfrom
buddhaplex:master

Conversation

@buddhaplex
Copy link
Copy Markdown

No description provided.

@buddhaplex buddhaplex changed the title Eric Andrade Eric Andrade working with Subra and Aaron Mar 28, 2018
@justinborek
Copy link
Copy Markdown

What Went Well:

Nice start on this one. You had a nice mobile implementation and you had a nice start on the class syntax. By the end of the HTML you had started using BEM pretty well. It seems like you're getting the material but just needed more time. Nice job.

Areas For Improvement:

Hopefully the solution lecture pointed you in the right direction on the JS stuff. Your logic was starting to come together on your solution. When it comes to the BEM conventions, remember that you don't HAVE to use the term Block it's just a term for the highest order type of name. So where you used:

<div class="Section">
		<div class="Block Box">
			<div class="Block__placeholder">
				<h3 class="Block__h3">

you could have done:

<div class="Section">
		<div class="Box">
			<div class="Box__placeholder">
				<h3 class="Box__h3">

Questions:

None.

Rating (1-3):

2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants