Eric Andrade working with Subra and Aaron#76
Open
buddhaplex wants to merge 4 commits intobloominstituteoftechnology:masterfrom
Open
Eric Andrade working with Subra and Aaron#76buddhaplex wants to merge 4 commits intobloominstituteoftechnology:masterfrom
buddhaplex wants to merge 4 commits intobloominstituteoftechnology:masterfrom
Conversation
What Went Well:Nice start on this one. You had a nice mobile implementation and you had a nice start on the class syntax. By the end of the HTML you had started using BEM pretty well. It seems like you're getting the material but just needed more time. Nice job.Areas For Improvement:Hopefully the solution lecture pointed you in the right direction on the JS stuff. Your logic was starting to come together on your solution. When it comes to the BEM conventions, remember that you don't HAVE to use the term
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.