Nalee Riddell --- Components-BEM#75
Open
odax wants to merge 3 commits intobloominstituteoftechnology:masterfrom
Open
Nalee Riddell --- Components-BEM#75odax wants to merge 3 commits intobloominstituteoftechnology:masterfrom
odax wants to merge 3 commits intobloominstituteoftechnology:masterfrom
Conversation
What Went Well:Nice start on this one! Other than the error with the dropdown everything looks good, and your code looks good as well. Nice use of the BEM conventions as well. Your commit messages are good as well.Areas For Improvement:I figured out the error you were having. For your script declaration you were using:I was able to get it working by changing it to:The defer tag tells Javascript to wait until the page parses to run the scripts. What was happening under the hood was that your Javascript was trying to run when the classes hadn't actually been declared so it couldn't find the variables. There you go! Changing that one line makes the whole thing work.Questions:None.Rating (1-3): 2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.