Kevin's Components-BEM PR#74
Open
ktan114 wants to merge 17 commits intobloominstituteoftechnology:masterfrom
Open
Kevin's Components-BEM PR#74ktan114 wants to merge 17 commits intobloominstituteoftechnology:masterfrom
ktan114 wants to merge 17 commits intobloominstituteoftechnology:masterfrom
Conversation
frogr
approved these changes
Mar 29, 2018
frogr
left a comment
frogr
left a comment
There was a problem hiding this comment.
This is awesome!
I think the only complaint that I have is that the dropdown is super wide. It covers a lot of the text and in a real website that'd probably be poor UX. But it actually has a cool drop shadow and looks super good, the only problem is that it covers text.
Besides that though? No complaints! Your CSS naming is super consistent and clean, the Javascript looks solid, you used class syntax and everything. I love it!
Nice work!
| // console.log(childDropdown); | ||
|
|
||
| // Dropdown constructor | ||
| class Dropdown { |
There was a problem hiding this comment.
Glad you guys used es6 syntax -- super cool!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.