Skip to content

Components-BEM I Kevin Tan Mathias Bakken Justin Hong#73

Open
JustinSHong wants to merge 14 commits intobloominstituteoftechnology:masterfrom
JustinSHong:master
Open

Components-BEM I Kevin Tan Mathias Bakken Justin Hong#73
JustinSHong wants to merge 14 commits intobloominstituteoftechnology:masterfrom
JustinSHong:master

Conversation

@JustinSHong
Copy link
Copy Markdown

completed objectives for components-Bem day 1

Copy link
Copy Markdown

@BonnW BonnW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Guys!

Great job on the Project today!

You all have a lot of good commits and I'm really happy to see comments and console.logs.

In terms of styling, there's some weird discrepencies in Box.css. Some tags are indented more than others. This is not a big issue but please remember it is important to stay consistent.

Another thing is that within your index.js you should use const instead of let since those values do not change. Also, I see that on line two you have a variable named dropDown and on line 8 your class is named Dropdown. Try to keep your variable names from looking too similar. You can see how easily this can become a cause for confusion in a larger program.

Otherwise, everything looks good. Fantastic job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants