Open
Conversation
added 2 commits
June 20, 2018 14:34
-Added a nav to the top and centered it -Added two columns into a row -Added a jumbotron -Added a carousel of photos
-Added cards into a row -Can't actually remember what else, promise I'll get better at this!
|
Liz you did an excellent job with this project. Commit messages are detailed and I love that you are using the multi-line comments. I do wish there were more commits in general. No one will ever fault you for having too many so remember to commit often. There are quite a few empty lines in both your less files and the html. While these can make it easy to read when you are writing the code, you typically want to take these out at the end. Makes it more readable for someone that is coming into your project blind. Its a minor thing and something that an extension such as prettier may clear up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.