Export Value
and ParameterValue
type aliases
#79
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #78
Describe your changes
Value
type has been replaced byColumnValue
andParameterValue
types, both of which are exposed via bothcdb2.py
anddbapi2.py
modules. Updated anything that uses theValue
type to now use one of those two types.Testing performed
Currently no tests. I could create a series of tests that look like below, but I'm not sure how value-added that is, since none of the other exports from any modules are similarly tested.
or I could build a test that creates a fake package that imports these types and then runs
mypy
, but again I'm not sure how value-added that is.Additional context
Spoke with Matt about this change and he suggested breaking it into the two types, since
Value
was used for both parameters and for column values returned inside result sets. I've adjusted functions that useValue
to use one of the two replacements. We aren't going to similarly expose theRow
type since it just aliasesAny
, and it's not a big DevX burden to just useAny
forRow
.