Declare fetchmany and fetchall to return lists instead of Sequence
#71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously their annotations used the less specific `Sequence` type, despite the docstring saying that lists are returned. This caused type checkers to reject concatenating two result sets with `+`. Signed-off-by: Saharsh Rathi <[email protected]>
godlygeek
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
I rewrote your commit message to add details about the motivation for this change, but otherwise this LGTM. Thanks @Saharsh-R!
godlygeek
changed the title
fetchmany and fetchall to return lists instead of Sequence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Saharsh Rathi [email protected]
Closes #70
Describe your changes
I have changed the typing of return type of fetchall and fetchmany from
collections.abc.Sequence->typing.ListTesting performed
No tests written.
Additional context
Add any other context about your contribution here.