Interop #2585
Interop #2585
Conversation
isstuev
force-pushed
the
interop
branch
2 times, most recently
from
f07a0bf to
7f26d2f
Compare
There was a problem hiding this comment.
The files names could be more descriptive; for example, use .env.optimism_interop_0.
| @@ -461,6 +461,7 @@ This feature is **enabled by default** with the `coinzilla` ads provider. To swi | |||
| | NEXT_PUBLIC_ROLLUP_L2_WITHDRAWAL_URL | `string` | URL for L2 -> L1 withdrawals (Optimistic stack only) | Required for `optimistic` rollups | - | `https://app.optimism.io/bridge/withdraw` | v1.24.0+ | | |||
| | NEXT_PUBLIC_FAULT_PROOF_ENABLED | `boolean` | Set to `true` for chains with fault proof system enabled (Optimistic stack only) | - | - | `true` | v1.31.0+ | | |||
| | NEXT_PUBLIC_HAS_MUD_FRAMEWORK | `boolean` | Set to `true` for instances that use MUD framework (Optimistic stack only) | - | - | `true` | v1.33.0+ | | |||
| | NEXT_PUBLIC_INTEROP_ENABLED | `boolean` | Enables "Interop messages" page (Optimistic stack only) | - | `false` | `true` | v1.39.0+ | | |||
There was a problem hiding this comment.
Since this variable is specific to rollup, let's name it with the common prefix NEXT_PUBLIC_ROLLUP_*.
| // INTEROP | ||
| interop_messages: { | ||
| path: '/api/v2/optimism/interop/messages', | ||
| filterFields: [], | ||
| }, | ||
| interop_messages_count: { | ||
| path: '/api/v2/optimism/interop/messages/count', | ||
| }, |
There was a problem hiding this comment.
It is also better to prefix the names of these resources with optimistic_l2_, similar to optimistic_l2_deposits, optimistic_l2_withdrawals, etc. Additionally, place this code closer to the declaration of those resources.
| Q extends 'interop_messages' ? InteropMessageListResponse : | ||
| Q extends 'interop_messages_count' ? number : |
There was a problem hiding this comment.
Please move it to the ResourcePayloadRollups type
| // Modal, | ||
| // ModalContent, | ||
| // ModalCloseButton, |
There was a problem hiding this comment.
Lets's remove it if it is unnecessary.
There was a problem hiding this comment.
We can likely eliminate the gaps between the arrow and address snippets in the final line of the item, making it resemble the token transfers on the transaction page.
| const TxEntityInterop = ({ chain, hash, ...props }: Props) => { | ||
| const partsProps = distributeEntityProps(props); | ||
|
|
||
| const href = (chain?.instance_url && hash) ? chain.instance_url.replace(/\/$/, '') + route({ |
There was a problem hiding this comment.
If the replace function is intended to remove the trailing slash from a URL, it will be more readable if we use the utility function lib/stripTrailingSlash.ts.
There was a problem hiding this comment.
Shouldn't the ad banner be covered with an overlay similar to other test cases?
Description and Related Issue(s)
resolves #2588
Proposed Changes
added NEXT_PUBLIC_INTEROP_ENABLED env (optimistic only)
Checklist for PR author