Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
8c43ba9 to
19e8ffa
Compare
19e8ffa to
bbf71a9
Compare
bbf71a9 to
b3c3ea8
Compare
b3c3ea8 to
4ed667e
Compare
4ed667e to
7d05677
Compare
7d05677 to
a503206
Compare
a503206 to
bb90d5a
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds error reporting functionality for metadata fetching failures by exposing structured error information when off-chain metadata cannot be fetched or validated. The change enables API consumers to understand why metadata retrieval failed and handle errors appropriately.
Key changes:
- Added optional
errorobject to metadata schemas with standardized error codes and human-readable messages - Updated TypeScript type definitions to reflect the new error field
- Added comprehensive test coverage for the new error structure
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/schemas/pools/pool_metadata.yaml | Added error object schema to pool metadata |
| src/schemas/pools/pool_list_extended.yaml | Added error object schema to extended pool list metadata |
| src/schemas/governance/proposal_metadata_v2.yaml | Added error object schema to governance proposal metadata |
| src/generated-types.ts | Updated TypeScript interfaces with optional error field |
| openapi.yaml | Updated OpenAPI specification with error object definitions |
| openapi.json | Updated JSON OpenAPI specification with error object definitions |
| docs/blockfrost-openapi.yaml | Updated documentation OpenAPI specification |
| blockfrost-openapi.yaml | Updated public OpenAPI specification |
| test/tests/get-schema-for-endpoint.test.ts | Added test coverage for error object schema and fixed quote consistency |
| test/tests/snapshots/get-schema-for-endpoint.test.ts.snap | Updated test snapshots to include error object |
| CHANGELOG.md | Documented the new metadata error reporting feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prereq: #415