chore(ci): upgrade node to 24 (LTS) and remove stale dependabot ignores - #2350
Open
raiseandfall wants to merge 15 commits into
Open
chore(ci): upgrade node to 24 (LTS) and remove stale dependabot ignores#2350raiseandfall wants to merge 15 commits into
raiseandfall wants to merge 15 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
lparkerlm
approved these changes
Jul 17, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
v12.2+ breaks builds with allowJs:true and multiple outputs. Co-authored-by: Cursor <cursoragent@cursor.com>
raiseandfall
changed the title
lemoustachiste
requested changes
Jul 18, 2026
lemoustachiste
left a comment
lemoustachiste
left a comment
Member
There was a problem hiding this comment.
minor changes, but I'm not sure it is ideal to show the full error which caused rejection to the end user.
…preserve-caught-error lint rule Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
… ensureNotExpired test Co-authored-by: Cursor <cursoragent@cursor.com>
…sues
- Add strip-node-protocol plugin to redirect node:buffer/crypto/process
imports so rollup-plugin-polyfill-node can handle them (fixes node_buffer
is not defined at runtime)
- Use commonjs({ defaultIsModuleExports: true }) to fix randombytes/browser.js
default export interop with @blockcerts/ecdsa-secp256k1-verification-key-2019
- Replace rollup-plugin-node-globals with @rollup/plugin-inject for explicit
Buffer/process injection
Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2350 +/- ##
==========================================
+ Coverage 86.87% 86.96% +0.08%
==========================================
Files 176 176
Lines 2247 2247
Branches 381 381
==========================================
+ Hits 1952 1954 +2
+ Misses 181 180 -1
+ Partials 114 113 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-authored-by: Cursor <cursoragent@cursor.com>
lemoustachiste
approved these changes
Jul 20, 2026
lemoustachiste
left a comment
lemoustachiste
left a comment
Member
There was a problem hiding this comment.
I think if you open that door, trying to remove rollup-plugin-node-globals entirely would be great
Co-authored-by: Cursor <cursoragent@cursor.com>
…xtureV2 as JSON Co-authored-by: Cursor <cursoragent@cursor.com>
lparkerlm
approved these changes
Jul 20, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
lparkerlm
approved these changes
Jul 20, 2026
lemoustachiste
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates focused on modernizing dependencies, improving error handling, and enhancing CI/CD workflows. The most significant changes include updating Node.js and related tooling to newer versions, switching to improved error propagation with the
causeproperty, and refining the CI pipeline for better maintainability and release automation.Dependency and Tooling Updates:
.nvmrcand aligned the CI workflow to use the version specified in.nvmrc, ensuring consistency across development and CI environments. (.nvmrc,.github/workflows/ci.yml) [1] [2]package.json(such as@commitlint/cli,@eslint/js, andcommitlint) to their latest major versions for improved compatibility and security.CI/CD Workflow Improvements:
actions/checkout,actions/setup-node,codecov/codecov-action) and replaced the manual release step with thecycjimmy/semantic-release-actionfor more robust and automated release management. (.github/workflows/ci.yml) [1] [2].github/dependabot.yml)Error Handling Enhancements:
causeproperty toErrorobjects in several files (src/certificate.ts,src/inspectors/checkCredentialSchemaConformity.ts,src/inspectors/verifyIssuerProfile.ts, andsrc/parsers/parseV3.ts), making it easier to trace the root cause of errors during debugging. [1] [2] [3] [4]