Skip to content

fix(github): drop the cutover duration promise from progress surfaces #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aparajon merged 2 commits into from
Sep 1, 2026
Merged

fix(github): drop the cutover duration promise from progress surfaces #1240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
539f279
fix(github): drop the cutover duration promise from progress surfaces
aparajon Sep 1, 2026
bb4a6c9
fix(github): use glyph.Failed for the sharded table failure label
aparajon Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions TEMPLATES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4225,10 +4225,6 @@ ALTER TABLE `products` ADD INDEX `idx_price`(`price_cents`);
```


---

Cutover in progress — typically completes within seconds.

_Last updated: <relative-time datetime="2026-01-01T00:00:00Z">2026-01-01 00:00:00 UTC</relative-time> (2026-01-01 00:00:00 UTC)_

</details>
Expand Down Expand Up @@ -8318,7 +8314,6 @@ Defer cutover: Cutting over in progress
~ users: 🟦🟦🟦🟦🟦🟦🟦🟦🟦🟦🟦🟦🟦🟦🟦🟦🟦🟦🟦🟦 Cutting over...
ALTER TABLE `users` ADD INDEX `idx_email_created`(`email`, `created_at`);

Cutover in progress. This typically completes within seconds.
Tables are being renamed atomically...
```
</details>
Expand Down
1 change: 0 additions & 1 deletion pkg/cmd/internal/templates/preview_defer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,6 @@ func previewDeferCuttingOutput() {
}
WriteProgress(data)

fmt.Println("Cutover in progress. This typically completes within seconds.")
fmt.Println("Tables are being renamed atomically...")
}

Expand Down
3 changes: 0 additions & 3 deletions pkg/webhook/templates/apply.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1215,9 +1215,6 @@ func writeApplyFooter(sb *strings.Builder, data ApplyStatusCommentData) {
} else {
sb.WriteString("Recovering after restart. Cutover will be available once recovery completes.\n")
}
case state.Apply.CuttingOver:
sb.WriteString("\n---\n\n")
sb.WriteString("Cutover in progress — typically completes within seconds.\n")
case state.Apply.Running, state.Apply.RunningDegraded,
state.Apply.CatchingUp, state.Apply.Checksumming, state.Apply.PostChecksum:
if hasRetryingTable(data.Tables) {
Expand Down
2 changes: 1 addition & 1 deletion pkg/webhook/templates/sharded_apply.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ func shardedTableStatusPhrase(status string) string {
case state.Task.Recovering:
return "🔄 Recovering state..."
case state.Task.Failed:
return "❌ Failed"
return glyph.Failed + " Failed"
case state.Task.FailedRetryable:
return "🔄 Interrupted — retrying automatically"
case state.Task.Stopped:
Expand Down
Loading