fix(github): render cancelled as 🚫 and stopped as ⏹️ in state glyphs - #1148
Conversation
cb7af9a to
edf7c7c
Compare
bb8b258 to
e473cee
Compare
f63363a to
479f901
Compare
479f901 to
f9ffbf2
Compare
There was a problem hiding this comment.
Pull request overview
Aligns state glyph rendering across GitHub PR surfaces and the CLI so “cancelled” and “stopped” are represented consistently everywhere SchemaBot presents apply state.
Changes:
- Update per-deployment presentation state glyphs: Cancelled now renders as
🚫(instead of⛔) and Stopped as⏹️(instead of⏸). - Update CLI progress + stop-command output to render Stopped as
⏹️. - Refresh template/test expectations to match the new glyph vocabulary.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| TEMPLATES.md | Updates the documented stop-command output example to use ⏹️. |
| pkg/webhook/templates/sharded_apply_tenant_test.go | Updates expected shard “stopped” emoji to ⏹️. |
| pkg/presentation/presentation.go | Changes deployment-row glyphs for Stopped and Cancelled states. |
| pkg/presentation/presentation_test.go | Updates state→emoji mapping expectations for Stopped and Cancelled. |
| pkg/cmd/internal/templates/progress.go | Updates CLI rendering for Stopped state and stop success output to ⏹️. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The per-deployment state glyphs disagreed with the terminal summary comments on the same timeline: a cancelled deployment row showed ⛔ (the refusal glyph — nothing was refused) next to a 🚫 Cancelled headline, and a stopped row showed ⏸ while stopped tables and the terminal comment used ⏹️. Cancelled now renders 🚫 and stopped renders ⏹️ everywhere, including the CLI status line and stop-command output. ⏸ remains for genuinely paused states (paused/halted mid-flight, Defer Cutover options), which are transient rather than operator-terminal. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
f9ffbf2 to
99647b1
Compare
|
🤖 Review findings - created by Kiran's code review agent - for schemabot/pull/1148, 99647b1. Verdict: 2 findings — no blockers; 2 suggestions. The PR is a net improvement on both glyph collisions it targets. General suggestions
The one thing that could have broken, verifiedWhether moving cancelled off ⛔ collides with, or orphans, the severity vocabulary. It does neither, and this is the strongest argument for the change: ⛔ is Verified correct
This review was generated by Claude Code (claude-opus-5). |
Cancelled rendered as ⊘ in the per-table rows, the namespace group header, and the CLI progress lines while the headline used 🚫; every cancelled surface now uses 🚫. The two remaining bare ⏸ sites (paused, halted) gain the variation selector their sibling glyphs already carry, so every state glyph in a derived deployment measures two cells and padded columns stay aligned. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
🤖 Both suggestions taken, in bcbbbe7:
Fixtures and TEMPLATES.md regenerated in the same commit. Reply by Claude (Fable 5). |
Fixes the state-glyph split between per-deployment rows and the terminal summary comments on the same PR timeline:
🚫 Schema Change Cancelledheadline. Nothing was refused; the apply was cancelled. The CLI status line already rendered🚫 Cancelled, so the deployment row was the outlier.⏸️ Stoppedstatus line,⏸️ Schema change stoppedstop-command output) said ⏸. ⏸ now means only genuinely paused, transient states — paused/halted mid-flight and the Defer Cutover options — while ⏹️ means the operator-terminal stopped state.State glyphs are a separate vocabulary from the
pkg/glyphseverities and stay literal inpkg/presentation.Stacked on the webhook-surface PR; the base retargets as parents merge. This must ship in the same release as the webhook-surface PR.
Cancelled deployment row — before / after
Before:
After:
Stopped deployment row — before / after
Before:
After:
CLI stop command — before / after
Before:
After:
This PR was written by an AI agent (Claude Code, model Claude Fable 5) on behalf of the author.