test(client): cover mobile navigation visuals

[edgars-avotins]

🤖 Reviewable diff: +0/-0 across 0 files (excludes generated, test, and story files).

Summary

This PR closes a responsive visual-coverage gap where ProtoFleet navigation changes were detected on desktop but could pass unnoticed on mobile because the drawer stayed closed in every screenshot. It adds a focused navigation capture at the end of the existing sign-up and empty-state visual scenario, after all target content screenshots are complete.

How it works

The existing scenario continues through sign-up and every empty-state page with the mobile drawer closed. At the end, the shared visual helper opens the drawer only when needed, waits for the animated settings submenu to reach its final opacity and transform, then compares the main navigation landmark with a dedicated project snapshot.

Diagrams

flowchart LR
  A["Sign up and empty-state scenario"] --> B["Capture existing page targets"]
  B --> C["Prepare responsive navigation"]
  C --> D["Capture main navigation element"]
  D --> E["Compare project snapshot"]

Loading

Areas of the code involved

Area / package / file	What changed	Why it matters for review
client/e2eTests/protoFleet/spec/onboardingVisual.spec.ts	Adds the final navigation visual step	Confirms content screenshots remain unobstructed
client/e2eTests/protoFleet/helpers/onboardingVisuals.ts	Opens and captures the responsive navigation	Keeps responsive UI details out of the spec flow
Visual snapshot baselines	Adds desktop and mobile navigation expectations	Generated visual expectations; review the images directly

Key technical decisions & trade-offs

• Capture the navigation landmark after existing screenshots, over opening the drawer during page captures, so the drawer cannot hide the content under test.
• Extend the existing visual scenario, over adding another state-coupled test, to keep the fake-backend onboarding flow unchanged.
• Wait for the mobile submenu's final opacity and transform before capture so the approved baseline cannot preserve a transitional frame.

Testing & validation

• Initial probe checkpoint: desktop visual validation failed while mobile passed, reproducing the false positive.
• Corrected detection checkpoint: mobile failed specifically on navigation-menu-mobile.png with 3,010 differing pixels while the probe was retained.
• After removing the probe, the complete local visual spec passed for desktop (3/3) and mobile (3/3) in the CI-matching Playwright container.
• Final probe-free PR Gate passed, including desktop and mobile visual jobs, client tests, lint, formatting, typecheck, and build.
• Navigation unit tests, ProtoFleet build/typecheck, touched-file ESLint, formatting hooks, and diff checks pass locally.

[github-actions]

🔐 Codex Security Review

Note: This is an automated security-focused code review generated by Codex.
It should be used as a supplementary check alongside human review.
False positives are possible - use your judgment.

Scope summary

• Reviewed pull request diff only (2380449e020fecb5a42a9627af7c37c6f84cbf7f...7ed5b96caf8195793796bc40451024eda798e177, exact PR three-dot diff)
• Model: gpt-5.6-sol

💡 Click "edited" above to see previous reviews for this PR.

---

Review Summary

Overall Risk: NONE

Findings

No concrete security, correctness, or reliability issues were found in the changed hunks.

Notes

The new desktop and mobile visual baselines were inspected. Targeted lint could not run because dependencies were unavailable and network access was restricted.

---

_{Generated by Codex Security Review |
Triggered by: @edgars-avotins |
Review workflow run}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 332806b138

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[Copilot]

Pull request overview

This PR, as currently diffed, modifies ProtoFleet’s primary navigation configuration by adding a new “Visual probe” entry. The stated goal in the PR description (adding mobile navigation visual coverage in the ProtoFleet Playwright visual suite) is not reflected in the included changes.

Changes:

• Adds a new primaryNavItems entry for the /visual-probe path in ProtoFleet nav config.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ecb6c3bd55

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".