fix(audit): make delivery durable and tenant-fair - #7146
Draft
TheSentinel454 wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Luke Tornquist <tornquist@squareup.com>
🔐 Codex Security Review
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The follow-up review on #6229 identified audit-delivery gaps under database timeouts, tenant contention, and worker teardown. In particular, a supported
statement_timeoutcould lose an audit entry, one busy community could monopolize the bounded queue, and the idle-transaction test did not prove that PostgreSQL actually terminated and replaced the backend.What
Risk Assessment
Medium. This adds two community-scoped tables and changes audit delivery from process memory to PostgreSQL. The migration and deletion manifests are covered by schema tests, and the delivery path is protected by transactional enqueue/deduplication, per-community ordering, advisory locking, bounded retry backoff, and restart tests.
Verification
cargo clippy -p buzz-db -p buzz-audit -p buzz-relay --all-targets -- -D warningscargo test -p buzz-db --libcargo test -p buzz-auditcargo test -p buzz-audit -- --ignored --nocapture --test-threads=1cargo test -p buzz-relay --libReferences
Generated with Codex