Fix Codex security review authorization - #6913
Draft
jmecom wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Jordan Mecom <jm@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Codex security review workflow now authorizes automatic reviews from the live pull request instead of the webhook snapshot. This prevents a stale author association from sending an internal PR down the external-contributor invalidation path.
Internal PRs with no previous review now exit without attempting a comment or label mutation. The jobs that update PR comments and labels use
pull-requests: write, and the review job runs only after the trusted prepare step emitsauthorized=true.Regression tests cover stale author associations in both directions, the no-op invalidation path, and the mutation-job permission contract.
Checked with
just ci,just security-review-check, andactionlint .github/workflows/codex-security-review.yml.The failing
Mark Previous Review Stalecheck on this PR runs the pre-fixpull_request_targetworkflow frommain. GitHub will not execute this branch’s trusted workflow until it is merged; the new workflow contract and state-machine tests exercise the fix before then.