Skip to content

test(db): seed canonical large roster fixture - #6820

Closed
TheSentinel454 wants to merge 1 commit into
codex/issue-2-reaction-storefrom
codex/issue-2-feed-roster-test-fixtures
Closed

test(db): seed canonical large roster fixture#6820
TheSentinel454 wants to merge 1 commit into
codex/issue-2-reaction-storefrom
codex/issue-2-feed-roster-test-fixtures

Conversation

@TheSentinel454

@TheSentinel454 TheSentinel454 commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Current reconstructed head

Exact base: codex/issue-2-reaction-store at e2c71f5df1647e8a583ed3070c01fe7eb2bb85b3
Exact head: codex/issue-2-feed-roster-test-fixtures at 6fbb4cb7814f8d94cd438997141d2a1633d41907

This current head removes crates/buzz-db/tests/store_ownership.rs; no replacement path-sensitive ownership test is introduced. Apart from removing that complete test-file diff, the production patch is byte-for-byte identical to the previously reviewed slice. This remains part of tracker #2 and the #17/#19 acceptance work.

Independent exact-head review from a separate clean Blox workstation found no issues. Current-head evidence passed formatting, strict buzz-db clippy, 111 non-PostgreSQL library tests with 200 PostgreSQL tests ignored, the observability source test, relay consumer compilation, exact ownership/unique-span review checks, and 1 large-roster feed PostgreSQL regression test on native PostgreSQL where applicable.

Summary

Make the 11,000-member feed mention-indexing regression fixture canonical under migration 0032 before the feed store extraction adds more ownership to feed.rs.

The test now seeds the matching channel_members rows and emits four-field kind-39002 p tags with the authoritative member role. Its bind-parameter-cap assertion and 11,000-row scale are unchanged.

Stack

Why separate

The existing ignored test is red against a freshly migrated current main: migration 0032 rejects its legacy two-field roster tags before insert_mentions is exercised. The feed extraction PR is intended to move ownership without behavior changes, so this fixture correction is isolated in its own reviewable commit.

Non-goals

  • No production Rust or SQL changes.
  • No schema, lock, transaction, timeout, retry, API, or client-visible behavior changes.
  • No change to mention-index insertion or batching.
  • No feed store ownership movement; that remains in the child PR.

Risk

Low and test-only. The fixture still creates 11,000 unique mentions, exceeds the single-statement bind cap at six binds per row, and asserts every mention is indexed.

Blox verification

Author workstation: buzz-tornquist-issue-2-store-stack (2046520), native PostgreSQL 17.11.

  • Red before the change on a freshly migrated database: the focused test failed with migration 0032's kind 39002 roster contains an invalid p tag constraint.
  • cargo fmt --all --check: pass
  • git diff --check: pass
  • cargo clippy -p buzz-db --all-targets -- -D warnings: pass
  • feed::tests::insert_mentions_indexes_rosters_past_bind_parameter_cap: pass
  • Cumulative exact-tip PostgreSQL matrix: pass

Superseded pre-comment restack verification

PR #6700 merged before publication completed. This layer was restacked onto current main through the exact parent named above; the final cumulative tip is 2ddcc8a. Cumulative author gates passed: formatting and diff checks; buzz-db and buzz-relay all-target clippy with -D warnings; DB lib 111 passed / 200 ignored; ownership 22/22; observability 1/1; the full isolated PostgreSQL domain matrix; and relay lib 910 passed / 49 ignored.

Outcome

No actionable findings.

Reviewed the exact range b87cec6d690119721e2ef3ac34e6ba57b41099c7..ed21d81e7fe1fa7606c6e67412b788cc6df12916 on fresh Blox workstation buzz-tornquist-pr-6820-final-review (ID 2057635). The head is the direct child of the exact base. The test-only change seeds channel_members with the same 11,000 deterministic pubkeys emitted in four-field canonical roster p tags; it restores the large-roster bind-cap regression without changing production behavior.

Verification

  • cargo fmt --all --check, range/worktree git diff --check, and clean-tree checks passed.
  • cargo clippy -p buzz-db --all-targets -- -D warnings passed.
  • Non-PostgreSQL feed tests: 22 passed, 4 ignored.
  • cargo test -p buzz-relay --lib --no-run passed.
  • Native PostgreSQL 17: feed::tests::insert_mentions_indexes_rosters_past_bind_parameter_cap passed with the current migrations.
  • Final detached HEAD and merge-base were rechecked; the repository remained clean.

No code edits, commits, pushes, comments, or PR mutations were made. Buzz relay credentials were unavailable, so the private guide, ownership report, and workstream-channel updates were unavailable under the documented fallback. The workstation was deleted after artifacts were transferred.

Artifacts

  • Diff SHA-256: 4df56ed54eb6b5bba06fd26354e1937b40fddf785759dce475b10de6c67e4ad6
  • Verification log SHA-256: 931f2a86c0aaf54f51c1c70a6df0b359a759cdd40ceec22684628e679c72d806
  • Artifact archive SHA-256: 481b8bd4a98e1db2da8b2425f981109cbcaced6d11960083703ee1a4eed229ac

Comment-addressed restack

Review follow-up on #6777 removed only the low-value replaceable ownership source test. This PR was restacked onto its rewritten parent; its production patch is unchanged.

  • Exact base: 19f2b86a063cecd1521eb003225ec76acb5d8bf3
  • Exact head: f18b0d3fdc45610d375637c2585d8ae589762735
  • Final cumulative tip: 6fa2f104d42c6ba85bdf62e7ccb74ceaf4a84f67
  • Per-layer patch-ID and tree audits confirm this PR’s production diff is unchanged from its pre-comment head.
  • Cumulative Blox gate: formatting and diff checks; strict buzz-db/buzz-relay Clippy; DB lib 111 passed / 200 ignored; ownership 21/21; observability 1/1; every moved PostgreSQL test; relay lib 910 passed / 49 ignored.
  • Independent re-review at this exact head: no findings; fresh exact-parent/head Blox review passed fmt/diff, strict buzz-db Clippy, current ownership/observability guards, feed tests (22 passed / 4 ignored), the moved large-roster PostgreSQL fixture, and relay compilation.

@TheSentinel454
TheSentinel454 force-pushed the codex/issue-2-feed-roster-test-fixtures branch from ed21d81 to f18b0d3 Compare August 25, 2026 20:59
@TheSentinel454
TheSentinel454 force-pushed the codex/issue-2-feed-roster-test-fixtures branch from f18b0d3 to 02e35ff Compare August 26, 2026 14:33
@TheSentinel454
TheSentinel454 force-pushed the codex/issue-2-feed-roster-test-fixtures branch from 02e35ff to 6fbb4cb Compare August 26, 2026 15:53
@TheSentinel454
TheSentinel454 force-pushed the codex/issue-2-feed-roster-test-fixtures branch from 6fbb4cb to c0c5ba0 Compare August 27, 2026 20:07
Signed-off-by: OpenAI Codex <codex@openai.com>
@TheSentinel454

Copy link
Copy Markdown
Contributor Author

🤖 Superseded by #6987, which consolidates the remaining issue #2 store-extraction stack onto merged #6782. #6987 is an open draft at the independently reviewed exact head, and all exact-head CI checks are green. This PR remains available for review history; please continue review on #6987.

TheSentinel454 added a commit that referenced this pull request Aug 28, 2026
## Summary

Finish the remaining database-store extraction tracked by
[TheSentinel454#2](TheSentinel454#2)
in one reviewable PR.

This consolidates the previously stacked domain slices after #6782
merged. It preserves the runtime/store boundary established by #6660,
#6668, #6700, and #6782 while separating database runtime infrastructure
from domain-owned persistence:

- `runtime/` owns pool construction and sizing, writer/reader routing,
read sessions and route proofs, transaction infrastructure,
observability primitives, replica fencing, health support, migrations,
and cross-cutting runtime tests.
- `store/` owns domain records, SQL, row parsing, locks and invariants,
`Db` domain methods, focused tests, and logical-operation datastore
spans.
- `lib.rs` remains a 57-line compatibility facade that preserves
existing crate-root paths and `Db` method signatures through re-exports.

Domain coverage includes API tokens, authentication allowlists,
reminders, event queries, threads, reactions, feeds, users and DMs,
push, workflows/runs/approvals, relay membership and invites, product
feedback, moderation/admin moderation, relay admin actions/operators,
git repositories, archived identities, usage, partition maintenance,
deletion, channel membership inherited from merged #6782, and the final
runtime/store layout.

The branch has been rebased onto current `main`. Database changes that
landed there were incorporated rather than overwritten:
`relay_admin_actions.rs` and `relay_operators.rs` now live under
`store/`, their 27 public `Db` wrappers and existing behavior remain
intact, and every wrapper has exactly one fixed-name datastore span.
Concurrent changes to migration, moderation, admin moderation, and error
handling are also retained.

### Exact base and head

- Base: `main` at `ed11c8d8bf0a17402be5cf243724f89471530d2f`
- Head: `codex/issue-2-store-extraction` at
`be24430472d1a87ac5c0d6026c620cd6caea3537`

### Related issue

- Structural tracker:
[TheSentinel454#2](TheSentinel454#2)
- Domain trackers:
[#6](TheSentinel454#6),
[#7](TheSentinel454#7),
[#12](TheSentinel454#12),
[#13](TheSentinel454#13)
- Acceptance trackers:
[#17](TheSentinel454#17),
[#19](TheSentinel454#19)

This supersedes #6783, #6784, #6787, #6788, #6789, #6792, #6820, #6794,
#6796, #6797, #6798, #6799, #6804, #6805, #6806, #6808, #6809, #6811,
#6812, #6813, #6814, #6815, and #6890. Their discussions remain
available for review history.

### #17 / #19 acceptance

- Preserves the metric names, fixed labels, transaction/lock timing
boundaries, and privacy/cardinality constraints introduced by #6700.
- Keeps exactly one datastore span per public logical operation,
including the 27 relay-admin wrappers added on `main`.
- Removes `store_ownership.rs`; physical ownership and focused source
guards now enforce the boundary directly.
- Leaves no `impl Db`, domain SQL, focused domain test group, or
datastore span in `lib.rs`.
- Preserves existing public paths such as `buzz_db::channel`,
`buzz_db::event`, and `buzz_db::workflow` through crate-root re-exports
while keeping internal `runtime` and `store` namespaces private.

### Non-goals

- No SQL, schema, locking, transaction, retry, timeout, or
client-visible behavior changes.
- No generic store traits, domain handles, broad `PgExecutor` migration,
new store crate, raw pool accessor, or broader directory reorganization.
- No tracker issues are closed by this PR.

### Risk

The cumulative diff is large but structural. Risk is primarily
module-path, ownership, or conflict-resolution drift. It is mitigated by
preserving public re-exports, comparing the newly moved `main`
implementations to their upstream source, source guards, touched-crate
compilation, PostgreSQL-backed test coverage, and an independent
exact-head review on a separate clean Blox workstation.

### Testing

Author workstation `buzz-tornquist-pr-6987-rebase`, rebased branch
ending at exact head `be24430472d1a87ac5c0d6026c620cd6caea3537`:

- `cargo fmt --all --check`
- `cargo clippy -p buzz-db -p buzz-relay --all-targets -- -D warnings`
- `cargo test -p buzz-db --lib` — 113 passed, 240 PostgreSQL tests
intentionally ignored
- `cargo test -p buzz-db --test observability_source` — 2 passed
- PostgreSQL-backed `buzz-db` coverage under native PostgreSQL — 235
passed in the shared serial run; the five shared-state/config-sensitive
cases passed as isolated reruns against fresh schemas, including the two
owner-limit tests with their fixture's
`BUZZ_MAX_COMMUNITIES_PER_OWNER=3`
- `cargo test -p buzz-relay --lib -- --test-threads=1` under native
PostgreSQL/Redis — 991 passed; the three current-month
partition-sensitive identity-archive cases passed after provisioning the
August 2026 test partition; 87 infrastructure-marked tests remained
ignored
- Source/diff guards — relay-admin implementation bodies match current
`main`; all 27 public wrapper signatures are retained; exactly one
datastore span wraps each wrapper; `lib.rs` has zero `impl Db` blocks
and zero datastore spans; no duplicate top-level relay-admin modules or
`store_ownership.rs`; `error.rs` matches current `main`

Independent clean review workstation `buzz-tornquist-pr-6987-review`,
detached at exact head `be24430472d1a87ac5c0d6026c620cd6caea3537`:

- `cargo fmt --all --check`
- `cargo clippy -p buzz-db -p buzz-relay --all-targets -- -D warnings`
- `cargo test -p buzz-db --lib` — 113 passed, 240 ignored
- `cargo test -p buzz-db --test observability_source` — 2 passed
- Exact-head ownership/re-export/instrumentation audit — no remaining
actionable findings

---------

Signed-off-by: OpenAI Codex <codex@openai.com>
Signed-off-by: tornquist <tornquist@squareup.com>
Co-authored-by: OpenAI Codex <codex@openai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants