refactor(db): move admin moderation store ownership

[TheSentinel454]

Current reconstructed head

Exact base: codex/issue-2-usage-store at fad0f34b0d5abb9b24ac2c125e39654fec44c124
Exact head: codex/issue-2-admin-moderation-store at 102fca801dfdb3bab867deb4fab615718d03c6fc

This current head removes crates/buzz-db/tests/store_ownership.rs; no replacement path-sensitive ownership test is introduced. Apart from removing that complete test-file diff, the production patch is byte-for-byte identical to the previously reviewed slice. This remains part of tracker #2 and the #17/#19 acceptance work.

Independent exact-head review from a separate clean Blox workstation found no issues. Current-head evidence passed formatting, strict buzz-db clippy, 111 non-PostgreSQL library tests with 200 PostgreSQL tests ignored, the observability source test, relay consumer compilation, exact ownership/unique-span review checks, and 3 admin-moderation PostgreSQL tests on native PostgreSQL where applicable.

Summary

Continue tracker #2 by making admin_moderation.rs own the admin report and product-feedback read projections. Their records, SQL/parsers, and focused PostgreSQL tests already lived there; this child moves the four remaining Db methods and their datastore spans out of lib.rs.

The public Db API is unchanged. There is no dedicated domain issue for this slice; it completes another ledger item while advancing #17 and #19.

Stack

• Tracker: TheSentinel454/buzz#2
• Domain issue: none; admin moderation is a remaining tracker-led extraction
• Test ownership acceptance: #17
• Span ownership acceptance: #19
• Exact base: codex/issue-2-usage-store at 27378c8 (#6812)
• Exact head: codex/issue-2-admin-moderation-store at 7dbb399

Domain moved

• admin_list_reports
• admin_get_report
• admin_list_feedback
• admin_get_feedback
• Their four existing fixed-name PostgreSQL datastore spans

crates/buzz-db/src/lib.rs falls from 3,772 to 3,717 lines.

Non-goals

• Admin HTTP/API behavior or authorization
• Moderation writes, product-feedback ingestion, records, SQL, row parsing, schema, pagination, filtering, or client-visible behavior changes
• Generic store traits, raw pool access, executor migration, or crate reorganization

Risk

Low semantic risk. The four production methods and spans moved intact beside the records, parsers, SQL, and PostgreSQL tests they already used. Public signatures and query behavior are unchanged.

Blox verification

Author workstation: buzz-tornquist-issue-2-store-stack (2046520), exact head c684825860900357e017dd4102bc4df88dd6ec2e.

• cargo fmt --all --check
• git diff --check de6216580a94d060390ef8f319bad5ea7f242670..HEAD
• cargo clippy -p buzz-db --all-targets -- -D warnings
• cargo clippy -p buzz-relay --all-targets -- -D warnings
• cargo test -p buzz-db --lib: 108 passed, 200 ignored
• cargo test -p buzz-db --test observability_source: 1 passed
• Native PostgreSQL 17.11, migrations 1–32 already applied: all 3 admin_moderation::tests passed
• cargo test -p buzz-relay --lib: 909 passed, 48 ignored
• Commit hooks passed without bypass; the disposable workstation has no user signing key, so the commit itself is unsigned

Independent exact-head Blox review: no findings. Fresh workstation buzz-tornquist-pr-6813-review (2055307) verified exact geometry and reproduced format/diff checks, DB and relay clippy, DB library (108 passed, 200 ignored), ownership (20), observability (1), all 3 native-PostgreSQL admin-moderation tests, and relay library (909 passed, 48 ignored). Review artifact SHA-256: fbc410e0e70a7203f6eeec0d6ba655636ffc5c6b6e6cbafc6197d36f465e954d.

Remaining tracker work

Next: partition/event backfill maintenance, deletion-store facades, the remaining cross-domain helper audit, and the final runtime-boundary/test assessment.

Superseded pre-comment restack verification

PR #6700 merged before publication completed. This layer was restacked onto current main through the exact parent named above; the final cumulative tip is 2ddcc8a. Cumulative author gates passed: formatting and diff checks; buzz-db and buzz-relay all-target clippy with -D warnings; DB lib 111 passed / 200 ignored; ownership 22/22; observability 1/1; the full isolated PostgreSQL domain matrix; and relay lib 910 passed / 49 ignored.

Result

No findings.

Exact revision and isolation

• Base: d21fc19f455726960fff633b491d031697af6694
• Head: bcb1b423b7ac029759777209505800a757adc53b
• Verified head parent and merge-base: exact base above
• Reviewer workstation: buzz-tornquist-pr-6813-final-review (2057670)

The fresh shallow workstation was clean and unclaimed, had no competing commands, and had no Buzz production relay credentials or ownership-report file.

Review conclusions

• The four deployment-global admin moderation/feedback Db facades move intact into admin_moderation.rs.
• Optional tenant filters, cursor shape, bounded limits, returned records, SQL, and cross-tenant admin-plane semantics are unchanged.

Verification

• Diff check and Rust formatting: passed.
• Buzz DB and relay all-target clippy with -D warnings: passed.
• Buzz DB library: 111 passed, 200 ignored.
• Native PostgreSQL 17.11, migrations complete: all three admin-moderation tests passed.
• Final detached head remained clean; no duplicate datastore-span names were found.

Artifacts: pr-6813-final-review-artifacts.tgz, SHA-256 72e98d736d038895e354a04103b0f94b17d4de96cb1d05300e24c3c10c44d803. Archive and internal checksums were verified locally.

Comment-addressed restack

Review follow-up on #6777 removed only the low-value replaceable ownership source test. This PR was restacked onto its rewritten parent; its production patch is unchanged.

• Exact base: 27378c8f13143efed9815abc17e4c7efba572d2f
• Exact head: 7dbb399207515d12fc9b27036076e5d4f6bfb937
• Final cumulative tip: 6fa2f104d42c6ba85bdf62e7ccb74ceaf4a84f67
• Per-layer patch-ID and tree audits confirm this PR’s production diff is unchanged from its pre-comment head.
• Cumulative Blox gate: formatting and diff checks; strict buzz-db/buzz-relay Clippy; DB lib 111 passed / 200 ignored; ownership 21/21; observability 1/1; every moved PostgreSQL test; relay lib 910 passed / 49 ignored.
• Independent re-review at this exact head: no findings; fresh exact-parent/head Blox review passed fmt/diff, strict buzz-db/buzz-relay Clippy, DB lib and current ownership/observability/unique-span guards, 3 admin-moderation PostgreSQL tests, and relay compilation.

[TheSentinel454]

🤖 Superseded by #6987, which consolidates the remaining issue #2 store-extraction stack onto merged #6782. #6987 is an open draft at the independently reviewed exact head, and all exact-head CI checks are green. This PR remains available for review history; please continue review on #6987.