refactor(db): move workflow run and approval ownership

[TheSentinel454]

Current reconstructed head

Exact base: codex/issue-2-workflow-store at 128397a2700ad22c9bd12b367ce5733db5d2a411
Exact head: codex/issue-2-workflow-runs-approval-store at 1db9c199a2e0029e38228a9bf9ecb78d8d61ab16

This current head removes crates/buzz-db/tests/store_ownership.rs; no replacement path-sensitive ownership test is introduced. Apart from removing that complete test-file diff, the production patch is byte-for-byte identical to the previously reviewed slice. This remains part of tracker #2 and the #17/#19 acceptance work.

Independent exact-head review from a separate clean Blox workstation found no issues. Current-head evidence passed formatting, strict buzz-db clippy, 111 non-PostgreSQL library tests with 200 PostgreSQL tests ignored, the observability source test, relay consumer compilation, exact ownership/unique-span review checks, and 8 workflow/run/approval PostgreSQL tests on native PostgreSQL where applicable.

Why

Complete the workflow-domain extraction identified by tracker #2. Parent #6798 moved workflow definition and scheduling ownership; this child moves the remaining workflow-run and approval Db APIs and datastore spans beside their existing records, SQL, parsers, and focused tests in workflow.rs.

What

• Move five workflow-run Db APIs and their datastore spans into workflow.rs
• Move six approval Db APIs and their datastore spans into workflow.rs
• Preserve create/get/list/keyset-page/update run behavior and public signatures
• Preserve approval token hashing/lookups, status updates, run scoping, and public signatures
• Keep all workflow/run/approval records, enums, parameter structs, SQL, row parsing, and eight focused PostgreSQL tests in workflow.rs
• Keep cross-domain workflow usage aggregation in lib.rs

Stack

• Exact base: codex/issue-2-workflow-store at d8ac1da (#6798)
• Exact head: codex/issue-2-workflow-runs-approval-store at 723b40d
• Tracker: buzz-db: break up lib.rs — move impl Db methods to domain modules TheSentinel454/buzz#2
• Domain issue: none; this completes the workflow/run/approval domain identified by the extraction ledger
• Test/span acceptance: buzz-db: move lib.rs tests (~4,000 lines) to domain modules TheSentinel454/buzz#17 and buzz-db: consistent #[datastore_span] tracing placement TheSentinel454/buzz#19

Non-goals

• No SQL, schema, token hashing, transaction, retry, timeout, pagination, status, or client-visible behavior changes
• No movement of cross-domain usage aggregation out of lib.rs
• No store traits, domain-handle redesign, broad PgExecutor migration, raw pool accessor, new crate, or directory-wide reorganization
• No changes to, retargeting of, or merge action on parent PRs or PR Add database pressure observability #6700

Risk Assessment

Moderate review surface, low semantic risk. The eleven wrappers and spans moved intact and still call the same workflow SQL functions with the same pool, arguments, return types, and ordering. Records, SQL, hashing, and tests were already module-owned.

Blox Verification

Author workstation: buzz-tornquist-issue-2-store-stack (2046520), exact head c74438e849c57d4840122d674edf1a989a54d37c.

• cargo fmt --all --check and git diff --check — passed
• cargo clippy -p buzz-db -p buzz-relay --all-targets -- -D warnings — passed
• cargo test -p buzz-db --quiet — 108 passed, 200 ignored
• Native PostgreSQL migrations 1–32 followed by workflow::tests:: — 8 passed, including approval confinement
• cargo test -p buzz-relay --lib -- --test-threads=1 — 909 passed, 48 ignored
• Commit-time formatting, sadscan, attribution, and sign-off hooks — passed

Independent exact-head Blox review completed on buzz-tornquist-pr-6799-review (2052518) with no findings at any severity.

Generated with Codex

Superseded pre-comment restack verification

PR #6700 merged before publication completed. This layer was restacked onto current main through the exact parent named above; the final cumulative tip is 2ddcc8a. Cumulative author gates passed: formatting and diff checks; buzz-db and buzz-relay all-target clippy with -D warnings; DB lib 111 passed / 200 ignored; ownership 22/22; observability 1/1; the full isolated PostgreSQL domain matrix; and relay lib 910 passed / 49 ignored.

Outcome

No actionable findings.

Reviewed exact direct-parent range 6c2b24cd97e116e1b311105f2ed2d381f86df3dc..acbcc4abe1a9ab035eb9ffcf87a3d380d5ce1b6e on fresh Blox workstation buzz-tornquist-pr-6799-final-review (ID 2057731). Eleven workflow run/approval wrappers retain signatures, token-hash handling, community scoping, SQL delegates, and one datastore span each after moving to workflow.rs. Usage aggregation remains cross-domain and runtime-owned.

Verification

• Formatting, range/worktree diff checks, touched-crate clippy, and clean-tree checks passed.
• Non-PostgreSQL workflow tests: 24 passed, 8 ignored.
• Relay consumer compile passed.
• Native PostgreSQL 17: all 8 workflow PostgreSQL tests passed.
• Exact head and merge-base were rechecked.

No code edits or external mutations were made. Buzz relay credentials/ownership reporting were unavailable under the documented fallback. The workstation was deleted after artifact transfer.

Artifacts

• Diff SHA-256: aec305291dcf11c6ea2eeb80ce4e06c111268edef8ed0cf7752b0091e08322ed
• Verification log SHA-256: 1b9ee51fd59e27ab737f87ea8f5c54a50c95098e84069d7734dbf4bdfdb53e9f
• Artifact archive SHA-256: c7b0ed7feeeadb87fac902c73ec7220adf0ccecf35043338702a5156afa6c8eb

Comment-addressed restack

Review follow-up on #6777 removed only the low-value replaceable ownership source test. This PR was restacked onto its rewritten parent; its production patch is unchanged.

• Exact base: d8ac1da0a9d44649344dc90ea8e569e49c8bb58d
• Exact head: 723b40d924744483328cf436f8d946e8176e3aba
• Final cumulative tip: 6fa2f104d42c6ba85bdf62e7ccb74ceaf4a84f67
• Per-layer patch-ID and tree audits confirm this PR’s production diff is unchanged from its pre-comment head.
• Cumulative Blox gate: formatting and diff checks; strict buzz-db/buzz-relay Clippy; DB lib 111 passed / 200 ignored; ownership 21/21; observability 1/1; every moved PostgreSQL test; relay lib 910 passed / 49 ignored.
• Independent re-review at this exact head: no findings; fresh exact-parent/head Blox review passed fmt/diff, strict buzz-db Clippy, current ownership/observability guards, workflow tests (24 passed / 8 ignored), all 8 workflow PostgreSQL tests, and relay compilation.

[TheSentinel454]

🤖 Superseded by #6987, which consolidates the remaining issue #2 store-extraction stack onto merged #6782. #6987 is an open draft at the independently reviewed exact head, and all exact-head CI checks are green. This PR remains available for review history; please continue review on #6987.