fix(desktop): show remote agent activity in DMs - #6453
Open
ScaleLeanChris wants to merge 1 commit into
Open
Conversation
Signed-off-by: ScaleLeanChris <chris@scalelean.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The agent was alive and kicking, but Desktop classified its DM typing as human activity because its declared ordinary-channel scopes did not match the DM identifier. The separate typing path still rendered
Hermes is typing..., while the detailed agent activity surface had no matching agent session.DM membership is already the authoritative relationship for that conversation. This change uses it only after the identity has entered the managed, relay-directory, or member-bot candidate set. It does not turn arbitrary DM participants into agents and does not change relay authorization.
Related issue
Fixes #6439
Controlling work order: BAC-118
Testing
node --import ./test-loader.mjs --experimental-strip-types --test src/features/channels/ui/useChannelActivityTyping.test.mjs: 11 passed, 0 failed.pnpm -C desktop typecheck: passed.pnpm exec biome check src/features/channels/ui/useChannelAgentSessions.ts src/features/channels/ui/useChannelActivityTyping.test.mjs: passed.just ci: passed on macOS with Flutter 3.41.7. This includes 5,250 Desktop tests, 2,701 Desktop Rust tests with 18 ignored, and 1,552 mobile tests.Screenshots are not included because this changes no layout or copy. It restores the existing detailed activity surface for the affected DM classification path. The focused regression exercises the production candidate builder and session filter together.