Skip to content

fix(desktop): clarify add agents channel action #6374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomaspblock merged 3 commits into from
Aug 21, 2026
+12 −5
Merged

fix(desktop): clarify add agents channel action #6374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ace382
fix(desktop): clarify add agents channel action
matt2e Aug 20, 2026
2978692
fix(desktop): shorten add agents channel copy
matt2e Aug 21, 2026
1bec668
test(desktop): accept current channel activity copy
matt2e Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions desktop/src/features/channels/ui/useChannelIntro.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,9 @@ export function useChannelIntro({
if (!activeChannel.archivedAt && activeChannel.isMember) {
if (onAddAgent) {
actions.push({
description: "Add an agent here.",
description: "Bring them in.",
icon: <Bot aria-hidden className="h-6 w-6" />,
label: "Create agent",
label: "Add agents",
onClick: onAddAgent,
testId: "channel-intro-action-create-agent",
});
Expand Down
11 changes: 9 additions & 2 deletions desktop/tests/e2e/channels.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1746,8 +1746,15 @@ test("empty channel shows intro actions", async ({ page }) => {
await expect(
page.getByTestId("channel-intro-action-create-channel"),
).toHaveCount(0);
const addAgentsAction = page.getByTestId("channel-intro-action-create-agent");
await expect(addAgentsAction).toBeVisible();
await expect(
page.getByTestId("channel-intro-action-create-agent"),
addAgentsAction.getByText("Add agents", { exact: true }),
).toBeVisible();
await expect(
addAgentsAction.getByText("Bring them in.", {
exact: true,
}),
).toBeVisible();
await expect(
page.getByTestId("channel-intro-action-add-people"),
Expand All @@ -1767,7 +1774,7 @@ test("empty channel shows intro actions", async ({ page }) => {
await page.keyboard.press("Escape");
await expect(page.getByTestId("members-sidebar")).not.toBeVisible();

await page.getByTestId("channel-intro-action-create-agent").click();
await addAgentsAction.click();
await expect(page.getByRole("heading", { name: "Add agents" })).toBeVisible();

await page.keyboard.press("Escape");
Expand Down
2 changes: 1 addition & 1 deletion desktop/tests/e2e/tooltip-semantics.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ for (const theme of THEMES) {
await expect(row).toBeVisible();
await expectMutedSupportingText(
row.getByRole("button", { name: "Open channel general" }),
/Public channel · Active \d+[mhdw] ago/,
/Public channel · Active (just now|\d+[mhdw] ago)/,
);
await page.mouse.move(0, 0);
await expectMutedSupportingText(
Expand Down
Loading