Skip to content

fix(staged): resolve hashtag badge showing raw IDs instead of titles #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matt2e merged 4 commits into from
Apr 16, 2026
Merged

fix(staged): resolve hashtag badge showing raw IDs instead of titles #636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1f8f4e2
fix(staged): resolve hashtag badge titles in BranchCard timeline
matt2e Apr 15, 2026
1475783
refactor(staged): resolve review comments on hashtag badge fix
matt2e Apr 15, 2026
85c82ab
fix(staged): remove redundant "Review of" prefix in hashtag badge fal…
matt2e Apr 15, 2026
4a8327d
refactor(staged): use projectNotesToHashtagItems helper in BranchCard
matt2e Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions apps/staged/src/lib/features/branches/BranchCard.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
import RemoteWorkspaceStatusBadge from './RemoteWorkspaceStatusBadge.svelte';
import RemoteWorkspaceStatusView from './RemoteWorkspaceStatusView.svelte';
import { alerts } from '../../shared/alerts.svelte';
import { timelineToHashtagItems } from '../sessions/hashtagItems';
import { timelineToHashtagItems, projectNotesToHashtagItems } from '../sessions/hashtagItems';

interface Props {
branch: Branch;
Expand Down Expand Up @@ -115,15 +115,7 @@
let stale = false;
commands.listProjectNotes(projectId).then((notes) => {
if (stale) return;
projectNoteHashtagItems = notes
.filter((n) => n.title.trim())
.map((n) => ({
type: 'project-note' as const,
id: n.id,
title: n.title,
color: '--note-color',
bgColor: '--note-bg',
}));
projectNoteHashtagItems = projectNotesToHashtagItems(notes);
});
return () => {
stale = true;
Expand Down
4 changes: 2 additions & 2 deletions apps/staged/src/lib/features/sessions/hashtagItems.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ export function timelineToHashtagItems(
}

for (const review of timeline.reviews) {
const title = review.title || `Review of ${review.commitSha.slice(0, 7)}`;
const title = review.title || review.commitSha.slice(0, 7);
items.push({
type: 'review',
id: review.id,
Expand All @@ -116,7 +116,7 @@ export function timelineToHashtagItems(
return items;
}

function projectNotesToHashtagItems(notes: ProjectNote[]): HashtagItem[] {
export function projectNotesToHashtagItems(notes: ProjectNote[]): HashtagItem[] {
return notes
.filter((n) => n.title.trim())
.map((n) => ({
Expand Down
3 changes: 3 additions & 0 deletions apps/staged/src/lib/features/timeline/BranchTimeline.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,6 +592,9 @@
<TimelineRow
type={item.type}
title={item.title}
titleHtml={hashtagItems.length > 0 && hasHashtagTokens(item.title)
? renderHashtagTokens(item.title, hashtagItems)
: undefined}
secondaryMeta={item.sessionId
? (liveSessionHints[item.sessionId] ??
item.secondaryMeta ??
Expand Down