Skip to content

fix: typo in English translation for user password reset#1155

Merged
DLHTX merged 1 commit intoblinkospace:mainfrom
eugencowie:patch-1
Apr 12, 2026
Merged

fix: typo in English translation for user password reset#1155
DLHTX merged 1 commit intoblinkospace:mainfrom
eugencowie:patch-1

Conversation

@eugencowie
Copy link
Copy Markdown
Contributor

Fixes a typo in the English translation for user password reset (Rest -> Reset):
image

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 9, 2026
Copy link
Copy Markdown
Collaborator

@blinko-space blinko-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: APPROVE ✅

Reviewed locally via automated pipeline.

Code review:

  • ✓ Correct fix: RestReset in app/public/locales/en/translation.json:68
  • ✓ Only the English locale is touched — no other translation file clobbered
  • ✓ Verified the key rest-user-password is actually consumed in app/src/components/BlinkoSettings/BasicSetting.tsx, so the fix takes effect in the UI
  • ⚠ Minor note (out of scope): the translation key name itself still has the typo (rest-user-password). Renaming it would require updating every locale file + the caller, so leaving it for a follow-up is the right call.

Runtime verification: Skipped — pure 1-line i18n value change, no runtime risk.

Good catch, thanks for the PR! 🙌

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 12, 2026
@DLHTX DLHTX merged commit 715bc6b into blinkospace:main Apr 12, 2026
1 check passed
@eugencowie eugencowie deleted the patch-1 branch April 12, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants