fix: typo in English translation for user password reset#1155
Merged
DLHTX merged 1 commit intoblinkospace:mainfrom Apr 12, 2026
Merged
fix: typo in English translation for user password reset#1155DLHTX merged 1 commit intoblinkospace:mainfrom
DLHTX merged 1 commit intoblinkospace:mainfrom
Conversation
blinko-space
approved these changes
Apr 12, 2026
Collaborator
blinko-space
left a comment
There was a problem hiding this comment.
Review: APPROVE ✅
Reviewed locally via automated pipeline.
Code review:
- ✓ Correct fix:
Rest→Resetinapp/public/locales/en/translation.json:68 - ✓ Only the English locale is touched — no other translation file clobbered
- ✓ Verified the key
rest-user-passwordis actually consumed inapp/src/components/BlinkoSettings/BasicSetting.tsx, so the fix takes effect in the UI - ⚠ Minor note (out of scope): the translation key name itself still has the typo (
rest-user-password). Renaming it would require updating every locale file + the caller, so leaving it for a follow-up is the right call.
Runtime verification: Skipped — pure 1-line i18n value change, no runtime risk.
Good catch, thanks for the PR! 🙌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a typo in the English translation for user password reset (Rest -> Reset):
