Patches for enabling badges synchronization from Blender ID #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brechtvl @sergeyvfx please let me know if you have any concerns regarding these patches |
brechtvl
approved these changes
Apr 2, 2025
There was a problem hiding this comment.
The code look good to me.
@bartvdbraak is the one managing the patches in this branch, so I think this should be coordinated with him if you aren't doing that already.
|
Thank you for reviewing so quickly! Yes, I'm coordinating this with Bart. |
bartvdbraak
force-pushed
the
sync-badges-patches
branch
from
e3fea49 to
705b7d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These patches will let us start synchronization of user badges from Blender ID.
The
badgetable needs to be populated manually, and updated in the future when new badges are introduced in Blender ID.Hopefully some automation for badge definitions becomes possible after go-gitea#31262
The synchronization is supposed to keep the
user_badgetable up to date via:updateBadgesIfNeedefunction introduced in patch 00160015 is needed to fix an upstream issue reported in go-gitea#33949
once the upstream is fixed, we can get rid of it.