Bugfix for "non-matching root node" bug#1
Open
brambg wants to merge 1 commit intobleekere:masterfrom
brambg:bugfix-abstract-segmenter
Open
Bugfix for "non-matching root node" bug#1brambg wants to merge 1 commit intobleekere:masterfrom brambg:bugfix-abstract-segmenter
brambg wants to merge 1 commit intobleekere:masterfrom
brambg:bugfix-abstract-segmenter
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the testLastSegment test (once you adjust the expectations) and my added test:
Since the addCelltoSuperwitness was effectively adding the lastCell to the superwitness, i changed the method name and parameters to reflect that. The "if (lastCell.match)" makes more sense now. (to me at least)