Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hailo Official integration #16906
base: dev
Are you sure you want to change the base?
Hailo Official integration #16906
Changes from 13 commits
eadd55e
7813476
c7e0e3c
3cc1382
16ffabf
1117729
ee45f50
323e4ce
8b5a100
62afebf
b1f2e29
2bdbad7
f99bb8e
aaad193
9bdc2d4
b8a20f5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should leave this in here, perhaps create a table like the other hardware sections so users know what to expect.
I am happy to do that separately if you can provide some inference times for the yolov6 model used here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain how the detector inference speed and Detector CPU usage is measured in your system metrics page?
We removed the table because we saw a mismatch between the inference speed measured in your metrics and the one we measure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is the total time of inference including image preprocessing and detection post processing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want these to be detector specific, I'd suggest just using yolo 9 as we may change that to be called yolo-generic or something in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Nick,
We've made this change to support all the models in our model zoo, not just YOLO. Any model, regardless of its configuration, can be run in Frigate as long as its post-processing is done on Hailo (which happens during the model compilation).
Regarding the default SSD MobileNet, it uses a 300x300 input size. Resizing from 320x320 to 300x300 takes more time than simply moving from 320x320 to 640x640. To optimize this, I've updated the detector to perform the resizing (so you can run Frigate with a 320x320 configuration) and use YOLOv6n with a 640x640 input size.
In summary, we now use the default 320x320 configuration for most models, and we only resize and run YOLOv6n with a 640x640 input size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, but this is a mixing of concerns, because now we have detectors that rely on the model type and model type that relies on the detector.
We either need the different model types to be listed out, or just have the Hailo detector ignore the configured model type when using a model from the Hailo zoo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did all the required changes , and improved performance by 3x , we need just to change something that is not correct and will re push